[
https://issues.apache.org/jira/browse/HBASE-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13684059#comment-13684059
]
stack commented on HBASE-7462:
------------------------------
This looks good [~gustavoanatoly]
Is this ok?
+ Mockito.when(master.getAssignmentManager()).thenReturn(am);
+
+ am = new AssignmentManager(server, serverManager, catalogTracker,
+ balancer, startupMasterExecutor("mockExecutorService"), null, null);
In other words adding the am to the mock but only in the line after actually
creating the AssignmentManager? Should the order be swapped?
Do you have to remove the old TestDrainingServer tests? The ones that spin up
a cluster?
> TestDrainingServer is an integration test. It should be a unit test instead
> ---------------------------------------------------------------------------
>
> Key: HBASE-7462
> URL: https://issues.apache.org/jira/browse/HBASE-7462
> Project: HBase
> Issue Type: Wish
> Components: test
> Affects Versions: 0.95.2
> Reporter: Nicolas Liochon
> Assignee: Gustavo Anatoly
> Priority: Trivial
> Labels: noob
> Attachments: HBASE-7462-v1.patch
>
>
> TestDrainingServer tests the function that allows to say that a regionserver
> should not get new regions.
> As it is written today, it's an integration test: it starts & stops a cluster.
> The test would be more efficient if it would just check that the
> AssignmentManager does not use the drained region server; whatever the
> circumstances (bulk assign or not for example).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
