[
https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688473#comment-13688473
]
Sergey Shelukhin commented on HBASE-8329:
-----------------------------------------
Looks reasonable.
{quote}
+ // Due to Compression, the number enlarged
{quote}
What does this comment mean?
{code}
+ 30 * 1000 * 1000 /* 30 MB/s */);
{code}
Should it be 1024?
{code}
+ if (elasp >= minTimeAllowed) {
+ // slow than the fast speed allowed.
+ } else {
{code}
Nit: this if condition is blank. Also elasp => elapsed?
Currently throttle relies on closeCheckInterval, which is 10Mb. Should there be
a separate parameter for that?
{code}
+ if (!store.areWritesEnabled()) {
+ bytesWritten = 0;
+ return false;
{code}
Nit: no point in setting the local before returning, if-return can be retained
from old code and bytesWritten simply moved after throttle.
There are long lines.
There are no unittests. Did you run in cluster?
> Limit compaction speed
> ----------------------
>
> Key: HBASE-8329
> URL: https://issues.apache.org/jira/browse/HBASE-8329
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
> Reporter: binlijin
> Attachments: HBASE-8329-2-trunk.patch, HBASE-8329-trunk.patch
>
>
> There is no speed or resource limit for compaction，I think we should add this
> feature especially when request burst.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
