[
https://issues.apache.org/jira/browse/HIVE-9971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366386#comment-14366386
]
Hive QA commented on HIVE-9971:
-------------------------------
{color:green}Overall{color}: +1 all checks pass
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12705177/HIVE-9971.5.patch
{color:green}SUCCESS:{color} +1 7770 tests passed
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3063/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3063/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3063/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12705177 - PreCommit-HIVE-TRUNK-Build
> Clean up operator class
> -----------------------
>
> Key: HIVE-9971
> URL: https://issues.apache.org/jira/browse/HIVE-9971
> Project: Hive
> Issue Type: Bug
> Reporter: Gunther Hagleitner
> Assignee: Gunther Hagleitner
> Attachments: HIVE-9971.1.patch, HIVE-9971.2.patch, HIVE-9971.3.patch,
> HIVE-9971.4.patch, HIVE-9971.5.patch
>
>
> This is mostly cleanup although it does enhance the pipeline in one respect.
> It introduces asyn init for operators and uses it for hash table loading
> where desired.
> There's a bunch of weird code associated with the operator class:
> - initialize isn't recursive, rather initializeOp is supposed to call
> initializeChildren. That has led to bugs in the past.
> - setExecContext and passExecContext. Both are recursive, but passExecContext
> calls setExecContext and then recurses again. Boo.
> - lots of (getChildren() != null) although that can't happen anymore
> - TezCacheAccess is a hack. We should just leave init of inputs up to the
> operator that needs it.
> - Need some sanity checks that make sure that operators were all initialized.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
