[ 
https://issues.apache.org/jira/browse/HIVE-8817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370071#comment-14370071
 ] 

Sergio Peña commented on HIVE-8817:
-----------------------------------

[~Ferd] - Could you post the patch on a review board? 

Here are a couple of comments, but I'd like to leave other ones in specific 
lines:

- Test fails with "java.lang.NullPointerException: Path cannot be null" at 
getKeyProviderURI() method. 
  Seems the 'hive.root' system variable does not exist.
  Can we make this test run without depending from other classes?
   
- Can we rename these constans so that it is more readable?
  HADOOP20SVERSIONNAME -> HADOOP_20S_VERSION_NAME
  HADOOP23VERSIONNAME -> HADOOP_23_VERSION_NAME

> Create unit test where we insert into an encrypted table and then read from 
> it with pig
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-8817
>                 URL: https://issues.apache.org/jira/browse/HIVE-8817
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: encryption-branch
>            Reporter: Brock Noland
>            Assignee: Ferdinand Xu
>             Fix For: encryption-branch
>
>         Attachments: HIVE-8817.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to