[
https://issues.apache.org/jira/browse/HIVE-9937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484929#comment-14484929
]
Gopal V commented on HIVE-9937:
-------------------------------
[~mmccline]: LGTM - +1.
Good test coverage - this is just a new fast SerDe + test-cases, without any
deviation for the main codepath until the new operators are introduced.
Reading a Decimal from Key instead of Value might be a corner case perhaps.
Before commit, can you verify the behavour of BinarySortableSerde on Decimal
(trailing zeros/precision) - something like vector_decimal_round.q should do as
a validity test.
> LLAP: Vectorized Field-By-Field Serialize / Deserialize to support new
> Vectorized Map Join
> ------------------------------------------------------------------------------------------
>
> Key: HIVE-9937
> URL: https://issues.apache.org/jira/browse/HIVE-9937
> Project: Hive
> Issue Type: Sub-task
> Reporter: Matt McCline
> Assignee: Matt McCline
> Attachments: HIVE-9937.01.patch, HIVE-9937.02.patch,
> HIVE-9937.03.patch, HIVE-9937.04.patch, HIVE-9937.05.patch,
> HIVE-9937.06.patch, HIVE-9937.07.patch, HIVE-9937.08.patch,
> HIVE-9937.09.patch, HIVE-9937.91.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
