[ 
https://issues.apache.org/jira/browse/HIVE-9664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511760#comment-14511760
 ] 

Sushanth Sowmyan commented on HIVE-9664:
----------------------------------------

One more note - this jira also makes changes in itests/pom.xml that are not 
portable:

{code}
diff --git a/itests/pom.xml b/itests/pom.xml
index 
fd4bb41fd8f74cdf261b791d1944dbca4b04f927..6f6cf742c41a11647589692ac4f266f467be2812
 100644
--- a/itests/pom.xml
+++ b/itests/pom.xml
@@ -93,6 +93,9 @@
                   mkdir -p $DOWNLOAD_DIR
                   download 
"http://d3jw87u4immizc.cloudfront.net/spark-tarball/spark-${spark.version}-bin-hadoop2-without-hive.tgz";
 "spark"
                   cp -f $HIVE_ROOT/data/conf/spark/log4j.properties 
$BASE_DIR/spark/conf/
+                  sed '/package /d' 
${basedir}/${hive.path.to.root}/contrib/src/java/org/apache/hadoop/hive/contrib/udf/example/UDFExampleAdd.java
 > /tmp/UDFExampleAdd.java
+                  javac -cp  
${settings.localRepository}/org/apache/hive/hive-exec/${project.version}/hive-exec-${project.version}.jar
 /tmp/UDFExampleAdd.java -d /tmp
+                  jar -cf /tmp/udfexampleadd-1.0.jar -C /tmp 
UDFExampleAdd.class
                 </echo>
               </target>
             </configuration>
{code}

sed is not something that's available in windows, and instead of compiling 
UDFExampleAdd.java in here, it might be better to create another quick jar 
build in the contrib package, and depend on it from the qtests to show that 
we're able to appropriately add jars. (Again, moving this to HIVE-10251 as well)

> Hive "add jar" command should be able to download and add jars from a 
> repository
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-9664
>                 URL: https://issues.apache.org/jira/browse/HIVE-9664
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.14.0
>            Reporter: Anant Nag
>            Assignee: Anant Nag
>              Labels: TODOC1.2, hive, patch
>             Fix For: 1.2.0
>
>         Attachments: HIVE-9664.4.patch, HIVE-9664.5.patch, HIVE-9664.patch, 
> HIVE-9664.patch, HIVE-9664.patch
>
>
> Currently Hive's "add jar" command takes a local path to the dependency jar. 
> This clutters the local file-system as users may forget to remove this jar 
> later
> It would be nice if Hive supported a Gradle like notation to download the jar 
> from a repository.
> Example:  add jar org:module:version
>         
> It should also be backward compatible and should take jar from the local 
> file-system as well. 
> RB:  https://reviews.apache.org/r/31628/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to