[
https://issues.apache.org/jira/browse/HIVE-10518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520905#comment-14520905
]
Lefty Leverenz commented on HIVE-10518:
---------------------------------------
HIVE-2482 had the erroneous underscore in @Description for encode & decode, but
correctly used a hyphen in all the test files.
Looks good to me.
+1
> Replace US_ASCII charset with US-ASCII in encode and decode description
> -----------------------------------------------------------------------
>
> Key: HIVE-10518
> URL: https://issues.apache.org/jira/browse/HIVE-10518
> Project: Hive
> Issue Type: Bug
> Components: UDF
> Reporter: Alexander Pivovarov
> Assignee: Alexander Pivovarov
> Priority: Trivial
> Attachments: HIVE-10518.1.patch
>
>
> GenericUDFEncode line 45 says
> {code}
> extended = "Possible options for the character set are 'US_ASCII',
> 'ISO-8859-1',\n" +
> {code}
> But Java Charset API says that valid ASCII charset value is US-ASCII
> https://docs.oracle.com/javase/7/docs/api/java/nio/charset/Charset.html
> java.nio.charset.StandardCharset line 44
> {code}
> public static final Charset US_ASCII = Charset.forName("US-ASCII");
> {code}
> http://grepcode.com/file/repository.grepcode.com/java/root/jdk/openjdk/7u40-b43/java/nio/charset/StandardCharsets.java#StandardCharsets
> So, US_ASCII (with underscore) is java constant name
> But the value is "US-ASCII" (with hyphen)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
