[
https://issues.apache.org/jira/browse/HIVE-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14526173#comment-14526173
]
Chaoyu Tang commented on HIVE-10587:
------------------------------------
The failed test seem not related to this patch.
> ExprNodeColumnDesc should be created with isPartitionColOrVirtualCol true for
> DP column
> ---------------------------------------------------------------------------------------
>
> Key: HIVE-10587
> URL: https://issues.apache.org/jira/browse/HIVE-10587
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Affects Versions: 1.0.0
> Reporter: Chaoyu Tang
> Assignee: Chaoyu Tang
> Priority: Minor
> Attachments: HIVE-10587.patch
>
>
> In SymenticAnalyzer method:
> Operator genConversionSelectOperator(String dest, QB qb, Operator input,
> TableDesc table_desc, DynamicPartitionCtx dpCtx) throws SemanticException
> ==
> The DP column's ExprNodeColumnDesc is created by passing false as the
> parameter isPartitionColOrVirtualCol value:
> {code}
> // DP columns starts with tableFields.size()
> for (int i = tableFields.size() + (updating() ? 1 : 0); i <
> rowFields.size(); ++i) {
> TypeInfo rowFieldTypeInfo = rowFields.get(i).getType();
> ExprNodeDesc column = new ExprNodeColumnDesc(
> rowFieldTypeInfo, rowFields.get(i).getInternalName(), "", false);
> expressions.add(column);
> }
> {code}
> I think it should be true instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
