[ 
https://issues.apache.org/jira/browse/HIVE-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527348#comment-14527348
 ] 

Chris Nauroth commented on HIVE-9736:
-------------------------------------

I figured we could make {{DefaultFileAccess#combine}} public, and then 
{{Hadoop23Shims}} could call it.  hive-shims-0.23 already has a dependency on 
hive-shims-common.  However, if there is a detail that I'm missing, then I 
wouldn't intend to hold up the patch over making that change.

+1 (non-binding) from me, and I defer to you on what's best to do with 
{{combine}} right now.  Thank you for the patch, and thank you for responding 
to the code review feedback!

> StorageBasedAuthProvider should batch namenode-calls where possible.
> --------------------------------------------------------------------
>
>                 Key: HIVE-9736
>                 URL: https://issues.apache.org/jira/browse/HIVE-9736
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore, Security
>            Reporter: Mithun Radhakrishnan
>            Assignee: Mithun Radhakrishnan
>         Attachments: HIVE-9736.1.patch, HIVE-9736.2.patch, HIVE-9736.3.patch, 
> HIVE-9736.4.patch, HIVE-9736.5.patch
>
>
> Consider a table partitioned by 2 keys (dt, region). Say a dt partition could 
> have 10000 associated regions. Consider that the user does:
> {code:sql}
> ALTER TABLE my_table DROP PARTITION (dt='20150101');
> {code}
> As things stand now, {{StorageBasedAuthProvider}} will make individual 
> {{DistributedFileSystem.listStatus()}} calls for each partition-directory, 
> and authorize each one separately. It'd be faster to batch the calls, and 
> examine multiple FileStatus objects at once.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to