[
https://issues.apache.org/jira/browse/HIVE-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527813#comment-14527813
]
Chaoyu Tang commented on HIVE-10608:
------------------------------------
[~apivovarov] The line "if
(e.getMessage().matches("(?s).*(IO|TTransport)Exception.*"));" should be a
comment. The caught MetaException should either be thrown out from
reloginExpiringKeytabUser or base.reconnect() which wrap only the IOException
or TTransportException at this moment, so there is no need to check the wrapped
exception since these two situations need retrying regardless.
> Fix useless 'if' stamement in RetryingMetaStoreClient (135)
> -----------------------------------------------------------
>
> Key: HIVE-10608
> URL: https://issues.apache.org/jira/browse/HIVE-10608
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Reporter: Alexander Pivovarov
> Assignee: Alexander Pivovarov
> Priority: Minor
>
> "if" statement below is useless because it ends with ;
> {code}
> } catch (MetaException e) {
> if (e.getMessage().matches("(?s).*(IO|TTransport)Exception.*"));
> caughtException = e;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
