[ 
https://issues.apache.org/jira/browse/HIVE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531523#comment-14531523
 ] 

Sushanth Sowmyan commented on HIVE-8696:
----------------------------------------

Also, on a related note, this section is way too brittle, and will likely break 
because of another exception chaining change sometime in the future, and is 
also very difficult to maintain from a readability perspective.

{code}
-      assertTrue(e.getCause().getMessage().contains(
+      
assertTrue(((InvocationTargetException)e.getCause().getCause().getCause()).getTargetException().getMessage().contains(
           "Could not connect to meta store using any of the URIs provided"));
{code}

I'm not going to ask to change that now, given that this patch itself is very 
important, and a blocker, but could you please file a follow up jira to clean 
up this testcase regarding this. :)

> HCatClientHMSImpl doesn't use a Retrying-HiveMetastoreClient.
> -------------------------------------------------------------
>
>                 Key: HIVE-8696
>                 URL: https://issues.apache.org/jira/browse/HIVE-8696
>             Project: Hive
>          Issue Type: Sub-task
>          Components: HCatalog, Metastore
>    Affects Versions: 0.12.0, 0.13.1
>            Reporter: Mithun Radhakrishnan
>            Assignee: Thiruvel Thirumoolan
>             Fix For: 1.2.0
>
>         Attachments: HIVE-8696.1.patch, HIVE-8696.2.patch, HIVE-8696.3.patch, 
> HIVE-8696.4.patch, HIVE-8696.poc.patch
>
>
> The HCatClientHMSImpl doesn't use a RetryingHiveMetastoreClient. Users of the 
> HCatClient API that log in through keytabs will fail without retry, when 
> their TGTs expire.
> The fix is inbound. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to