[ 
https://issues.apache.org/jira/browse/HIVE-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14537973#comment-14537973
 ] 

Aihua Xu commented on HIVE-10643:
---------------------------------

[~ashutoshc], can you help review the code? This is the first step with just 
refactoring the code. In the patch, we will pass WindowFrameDef around now, 
that will be used in the next tasks. 

I only did refactoring for sum() related stuff and later will work on sum() fix 
first since I believe the work for other UDAF functions should be similar to 
it. So I would prefer to work on one function first rather than refactoring 
everything at once.  

> Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers 
> (1 for number of preceding and 1 for number of following)
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-10643
>                 URL: https://issues.apache.org/jira/browse/HIVE-10643
>             Project: Hive
>          Issue Type: Sub-task
>          Components: PTF-Windowing
>            Reporter: Aihua Xu
>            Assignee: Aihua Xu
>            Priority: Minor
>         Attachments: HIVE-10643.patch
>
>
> The functionality should not be affected. Instead of passing 2 numbers (1 for 
> # of preceding rows and 1 for # of following rows), we will pass 
> WindowFrameDef object around. In the following subtasks, it will be used to 
> support additional window like {{rows between x preceding and y preceding}} 
> and {{rows between x following and y following}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to