[
https://issues.apache.org/jira/browse/HIVE-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543045#comment-14543045
]
Hari Sankar Sivarama Subramaniyan commented on HIVE-10696:
----------------------------------------------------------
[~apivovarov] Thank you for looking at the change. There are a couple of
reasons why I didnt use new Path(path).toUri() for both windows and linux.
1. It is a slightly more expensive call (which involves some additional
parsing) which is unnecessary can be avoided in non-windows since Linux or HDFS
always has / as the path delimiter.
2. There can be a case where a user can accidently pass escape sequence in the
jar path in unix and instead of getting an exception, he gets a valid URI
object which might get exposed elsewhere.
Apart from the minor reasons stated above using new Path().toUri() is fine in
both linux and windows.
Thanks
Hari
> TestAddResource tests are non-portable
> --------------------------------------
>
> Key: HIVE-10696
> URL: https://issues.apache.org/jira/browse/HIVE-10696
> Project: Hive
> Issue Type: Bug
> Reporter: Hari Sankar Sivarama Subramaniyan
> Assignee: Hari Sankar Sivarama Subramaniyan
> Attachments: HIVE-10696.1.patch
>
>
> We need to make sure these tests work in windows as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
