[ 
https://issues.apache.org/jira/browse/HIVE-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550719#comment-14550719
 ] 

Swarnim Kulkarni commented on HIVE-10748:
-----------------------------------------

We need to be certain though that we are only using it in places which are 
marked thread-unsafe because StringBuilder is also not synchronized(which is 
why it is faster). Or else build appropriate synchronization around it. 

> Replace StringBuffer with StringBuilder where possible
> ------------------------------------------------------
>
>                 Key: HIVE-10748
>                 URL: https://issues.apache.org/jira/browse/HIVE-10748
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Alexander Pivovarov
>            Assignee: Alexander Pivovarov
>            Priority: Minor
>
> I found 40 places in Hive where "new StringBuffer(" is used.
> "Where possible, it is recommended that StringBuilder be used in preference 
> to StringBuffer as it will be faster under most implementations"
> https://docs.oracle.com/javase/7/docs/api/java/lang/StringBuilder.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to