[
https://issues.apache.org/jira/browse/HIVE-16805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315033#comment-16315033
]
Hive QA commented on HIVE-16805:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12904949/HIVE-16805.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 18 failed/errored test(s), 11549 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_join25] (batchId=72)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[index_serde] (batchId=16)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=35)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb]
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucketsortoptimize_insert_2]
(batchId=151)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2]
(batchId=156)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
(batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid]
(batchId=168)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
(batchId=159)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb]
(batchId=159)
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_part]
(batchId=93)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5]
(batchId=120)
org.apache.hadoop.hive.metastore.TestEmbeddedHiveMetaStore.testTransactionalValidation
(batchId=213)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=253)
org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints
(batchId=225)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=231)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=231)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=231)
{noformat}
Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8491/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8491/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8491/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 18 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12904949 - PreCommit-HIVE-Build
> Utilities isEmptyPath Logging Too Chatty and Uses Bad Format
> ------------------------------------------------------------
>
> Key: HIVE-16805
> URL: https://issues.apache.org/jira/browse/HIVE-16805
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
> Affects Versions: 2.1.1, 3.0.0
> Reporter: BELUGA BEHR
> Assignee: BELUGA BEHR
> Priority: Minor
> Attachments: HIVE-16805.1.patch, HIVE-16805.2.patch
>
>
> {code:title=org.apache.hadoop.hive.ql.exec.Utilities}
> public static boolean isEmptyPath(JobConf job, Path dirPath, Context ctx)
> throws Exception {
> if (ctx != null) {
> ContentSummary cs = ctx.getCS(dirPath);
> if (cs != null) {
> LOG.info("Content Summary " + dirPath + "length: " + cs.getLength() +
> " num files: "
> + cs.getFileCount() + " num directories: " +
> cs.getDirectoryCount());
> return (cs.getLength() == 0 && cs.getFileCount() == 0 &&
> cs.getDirectoryCount() <= 1);
> } else {
> LOG.info("Content Summary not cached for " + dirPath);
> }
> }
> return isEmptyPath(job, dirPath);
> }
> {code}
> # This is too chatty. Logging for caching is not necessary for INFO logging.
> Move to DEBUG
> # Use Log4J's {} format
> # Make the messages more symmetrical - The success message doesn't include
> the word "cache" in it at all
> # Missing a space between the path and "length: " so the path is concatenated
> with the string "length:"
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
