[
https://issues.apache.org/jira/browse/HIVE-18355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317103#comment-16317103
]
Alan Gates commented on HIVE-18355:
-----------------------------------
A couple of comments in the build method:
# It should only set the owner if owner hasn't already been set. As it is now
it will override any owner the set in setOwner.
# Why the double try blocks, with the outer one catching all exceptions? The
outer block can be removed. If there are any uncaught exceptions as a result,
they should be caught and converted to MetaException in the inner block as
IOException is.
> Add builder for metastore Thrift classes missed in the first pass -
> FunctionBuilder
> -----------------------------------------------------------------------------------
>
> Key: HIVE-18355
> URL: https://issues.apache.org/jira/browse/HIVE-18355
> Project: Hive
> Issue Type: Bug
> Components: Standalone Metastore
> Affects Versions: 3.0.0
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Minor
> Attachments: HIVE-18355.patch
>
>
> Add a FunctionBuilder class
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
