[
https://issues.apache.org/jira/browse/HIVE-18349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317133#comment-16317133
]
Alan Gates commented on HIVE-18349:
-----------------------------------
HiveMetaStore.endFunction, lines 887 after your patch, I don't understand the
following addition:
{code}
if (!context.isSuccess() && context.getException() == null) {
888 throw new MetaException("Commit transaction failed");
889 }
{code}
Why should this method be throwing if the context says failure? Shouldn't that
be up to the calling methods? Also, since the context is passed to the end
function listener this means a broken end function listener that messed with
the context could cause metastore calls to fail.
> Misc metastore changes for debuggability, error on commit txn failures
> ----------------------------------------------------------------------
>
> Key: HIVE-18349
> URL: https://issues.apache.org/jira/browse/HIVE-18349
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 3.0.0
> Reporter: Prasanth Jayachandran
> Assignee: Prasanth Jayachandran
> Attachments: HIVE-18349.1.patch, HIVE-18349.2.patch,
> HIVE-18349.3.patch, HIVE-18349.4.patch, HIVE-18349.5.patch,
> HIVE-18349.6.patch, HIVE-18349.7.patch
>
>
> 1) Hive metastore audit event log/metastore log does not log the final status
> (success or failed) of the event. Some operations like for example,
> drop_table returns a boolean success flag but it never gets logged anywhere.
> However the same is sent to end event listeners or other metastore event
> listeners. It will be good to log the final status of the events.
> 2) Make connection timeout when using connection pool configurable. Currently
> its hard coded to 30 seconds.
> 3) Provide a config to enable connection leak detection for HikariCP or
> enable when debug logging is enabled.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
