[
https://issues.apache.org/jira/browse/HIVE-17982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318335#comment-16318335
]
Peter Vary commented on HIVE-17982:
-----------------------------------
Hi @alan gates,
AFAIK the ptest framework runs 2 drones on 1 server. This means 2 ssh script
runs 2 batches parallel so this might cause port grabbing in unfortunate
conditions. Also if we plan to run the tests parallel with surefire then we
might have the same problem too.
{quote}
Perhaps we could change startMetaStore to return the port it picked. We'd have
to check first that we always start the server first.
{quote}
I think the original code tried to do exactly this, or I might misunderstood
something:
{code}
public static int startMetaStoreWithRetry(final HadoopThriftAuthBridge
bridge, Configuration conf)
throws Exception {
Exception metaStoreException = null;
int metaStorePort = 0;
for (int tryCount = 0; tryCount < MetaStoreTestUtils.RETRY_COUNT;
tryCount++) {
try {
metaStorePort = MetaStoreTestUtils.findFreePort();
MetaStoreTestUtils.startMetaStore(metaStorePort, bridge, conf);
return metaStorePort;
} catch (ConnectException ce) {
metaStoreException = ce;
}
}
throw metaStoreException;
}
{code}
Thanks for all your effort put into this!
Peter
> Move metastore specific itests
> ------------------------------
>
> Key: HIVE-17982
> URL: https://issues.apache.org/jira/browse/HIVE-17982
> Project: Hive
> Issue Type: Sub-task
> Components: Standalone Metastore
> Reporter: Alan Gates
> Assignee: Alan Gates
> Labels: pull-request-available
> Attachments: HIVE-17982.patch
>
>
> There are a number of tests in itests/hive-unit/.../metastore that are
> metastore specific. I suspect they were initially placed in itests only
> because the metastore pulling in a few plugins from ql.
> Given that we need to be able to release the metastore separately, we need to
> be able to test it completely as a standalone entity. So I propose to move a
> number of the itests over into standalone-metastore. I will only move tests
> that are isolated to the metastore. Anything that tests wider functionality
> I plan to leave in itests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
