[ 
https://issues.apache.org/jira/browse/HIVE-18231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327626#comment-16327626
 ] 

Prasanth Jayachandran edited comment on HIVE-18231 at 1/16/18 7:17 PM:
-----------------------------------------------------------------------

Not sure if this patch will fix the following issue (if not let me know if you 
want this to be tracked separately)
{code:java|title=query}
0: jdbc:hive2://localhost:10000> show resource plans;
+----------+----------+--------------------+
| rp_name | status | query_parallelism |
+----------+----------+--------------------+
| global | ACTIVE | NULL |
| llap | ENABLED | NULL |
+----------+----------+--------------------+

0: jdbc:hive2://localhost:10000> ALTER TRIGGER global.highly_parallel ADD TO 
global.default;
Error: Error while compiling statement: FAILED: RuntimeException Empty Syntax 
Tree (state=42000,code=40000){code}
{code:java|title=exception}
org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: 
FAILED: RuntimeException Empty Syntax Tree
at 
org.apache.hive.service.cli.operation.Operation.toSQLException(Operation.java:313)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:204)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.operation.SQLOperation.runInternal(SQLOperation.java:289)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.hive.service.cli.operation.Operation.run(Operation.java:249) 
~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementInternal(HiveSessionImpl.java:541)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementAsync(HiveSessionImpl.java:527)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.CLIService.executeStatementAsync(CLIService.java:311)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.thrift.ThriftCLIService.ExecuteStatement(ThriftCLIService.java:564)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.rpc.thrift.TCLIService$Processor$ExecuteStatement.getResult(TCLIService.java:1557)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.rpc.thrift.TCLIService$Processor$ExecuteStatement.getResult(TCLIService.java:1542)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.auth.TSetIpAddressProcessor.process(TSetIpAddressProcessor.java:56)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
~[?:1.8.0_121]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
~[?:1.8.0_121]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]
Caused by: java.lang.RuntimeException: Empty Syntax Tree
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzerFactory.getInternal(SemanticAnalyzerFactory.java:210)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzerFactory.get(SemanticAnalyzerFactory.java:194)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:603) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1504) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1455) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:202)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]{code}
 Will be better to throw a user friendly error msg that can guide user to fix 
the issue. 


was (Author: prasanth_j):
Not sure if this patch will fix the following issue (if not let me know if you 
want this to be tracked separately)
{code:title=query}
0: jdbc:hive2://localhost:10000> show resource plans;
+----------+----------+--------------------+
| rp_name | status | query_parallelism |
+----------+----------+--------------------+
| global | ACTIVE | NULL |
| llap | ENABLED | NULL |
+----------+----------+--------------------+

0: jdbc:hive2://localhost:10000> ALTER TRIGGER global.highly_parallel ADD TO 
global.default;
Error: Error while compiling statement: FAILED: RuntimeException Empty Syntax 
Tree (state=42000,code=40000){code}
{code:title=exception}
org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: 
FAILED: RuntimeException Empty Syntax Tree
at 
org.apache.hive.service.cli.operation.Operation.toSQLException(Operation.java:313)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:204)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.operation.SQLOperation.runInternal(SQLOperation.java:289)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.hive.service.cli.operation.Operation.run(Operation.java:249) 
~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementInternal(HiveSessionImpl.java:541)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementAsync(HiveSessionImpl.java:527)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.CLIService.executeStatementAsync(CLIService.java:311)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.thrift.ThriftCLIService.ExecuteStatement(ThriftCLIService.java:564)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.rpc.thrift.TCLIService$Processor$ExecuteStatement.getResult(TCLIService.java:1557)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.rpc.thrift.TCLIService$Processor$ExecuteStatement.getResult(TCLIService.java:1542)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.auth.TSetIpAddressProcessor.process(TSetIpAddressProcessor.java:56)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:286)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
~[?:1.8.0_121]
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
~[?:1.8.0_121]
at java.lang.Thread.run(Thread.java:745) [?:1.8.0_121]
Caused by: java.lang.RuntimeException: Empty Syntax Tree
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzerFactory.getInternal(SemanticAnalyzerFactory.java:210)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hadoop.hive.ql.parse.SemanticAnalyzerFactory.get(SemanticAnalyzerFactory.java:194)
 ~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:603) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1504) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1455) 
~[hive-exec-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]
at 
org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:202)
 ~[hive-service-3.0.0-SNAPSHOT.jar:3.0.0-SNAPSHOT]{code}
 

> validate resource plan - part 2 - validate action and trigger expressions
> -------------------------------------------------------------------------
>
>                 Key: HIVE-18231
>                 URL: https://issues.apache.org/jira/browse/HIVE-18231
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Harish Jaiprakash
>            Priority: Major
>         Attachments: HIVE-18231.01.patch, HIVE-18231.02.patch
>
>
> The expression factories can probably be moved to metastore or common. Action 
> should be easy to verify; counter names in triggers cannot be verified, but 
> at least the expression form can be 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to