[ 
https://issues.apache.org/jira/browse/HIVE-18457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329732#comment-16329732
 ] 

Hive QA commented on HIVE-18457:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m  
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
46s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
52s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
34s{color} | {color:red} ql: The patch generated 15 new + 123 unchanged - 0 
fixed = 138 total (was 123) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
23s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 39s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 01816fc |
| Default Java | 1.8.0_111 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-8664/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-8664/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> improve show plan output (triggers, mappings)
> ---------------------------------------------
>
>                 Key: HIVE-18457
>                 URL: https://issues.apache.org/jira/browse/HIVE-18457
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 3.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Sergey Shelukhin
>            Priority: Major
>         Attachments: HIVE-18457.01.patch, HIVE-18457.patch
>
>
> Did the following sequence to add triggers to UNMANAGED. I can see the 
> triggers added to metastore by IS_IN_UNAMANGED flag is not set in metastore. 
> Also show resource plans does not show triggers in unmanaged pool.
> {code}
> 0: jdbc:hive2://localhost:10000> show resource plans;
> +----------+----------+--------------------+
> | rp_name  |  status  | query_parallelism  |
> +----------+----------+--------------------+
> | global   | ACTIVE   | NULL               |
> | llap     | ENABLED  | NULL               |
> +----------+----------+--------------------+
> 0: jdbc:hive2://localhost:10000>ALTER RESOURCE PLAN llap ACTIVATE;
> 0: jdbc:hive2://localhost:10000>ALTER RESOURCE PLAN global DISABLE;
> 0: jdbc:hive2://localhost:10000>CREATE TRIGGER global.highly_parallel WHEN 
> TOTAL_TASKS > 40 DO KILL;
> 0: jdbc:hive2://localhost:10000>ALTER TRIGGER global.highly_parallel ADD TO 
> UNMANAGED;
> 0: jdbc:hive2://localhost:10000>CREATE TRIGGER global.big_hdfs_read WHEN 
> HDFS_BYTES_READ > 3000000000 DO KILL;
> 0: jdbc:hive2://localhost:10000>ALTER TRIGGER global.big_hdfs_read ADD TO 
> UNMANAGED;
> 0: jdbc:hive2://localhost:10000>CREATE TRIGGER global.slow_query WHEN 
> EXECUTION_TIME > 100000 DO KILL;
> 0: jdbc:hive2://localhost:10000>ALTER TRIGGER global.slow_query ADD TO 
> UNMANAGED;
> 0: jdbc:hive2://localhost:10000>CREATE TRIGGER global.some_spills WHEN 
> SPILLED_RECORDS > 10 DO KILL;
> 0: jdbc:hive2://localhost:10000>ALTER TRIGGER global.some_spills ADD TO 
> UNMANAGED;
> 0: jdbc:hive2://localhost:10000>ALTER RESOURCE PLAN global ENABLE;
> 0: jdbc:hive2://localhost:10000>ALTER RESOURCE PLAN global ACTIVATE;
> 0: jdbc:hive2://localhost:10000> show resource plan global;
> +----------------------------------------------------+
> |                        line                        |
> +----------------------------------------------------+
> | global[status=ACTIVE,parallelism=null,defaultPool=default] |
> |     default[allocFraction=1.0,schedulingPolicy=null,parallelism=4] |
> +----------------------------------------------------+
> {code}
> {code:title=mysql}
> mysql> select * from wm_trigger;
> +------------+-------+-----------------+------------------------------+-------------------+-----------------+
> | TRIGGER_ID | RP_ID | NAME            | TRIGGER_EXPRESSION           | 
> ACTION_EXPRESSION | IS_IN_UNMANAGED |
> +------------+-------+-----------------+------------------------------+-------------------+-----------------+
> |         29 |     1 | highly_parallel | TOTAL_TASKS > 40             | KILL  
>             |                |
> |         33 |     1 | big_hdfs_read   | HDFS_BYTES_READ > 3000000000 | KILL  
>             |                |
> |         34 |     1 | slow_query      | EXECUTION_TIME > 100000      | KILL  
>             |                |
> |         35 |     1 | some_spills     | SPILLED_RECORDS > 10         | KILL  
>             |                |
> +------------+-------+-----------------+------------------------------+-------------------+-----------------+
> {code}
> From the above mysql table, IS_IN_UNMANAGED is not set and 'show resource 
> plan global' is not showing triggers defined in unmanaged pool. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to