[
https://issues.apache.org/jira/browse/HIVE-18492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336359#comment-16336359
]
Sergey Shelukhin commented on HIVE-18492:
-----------------------------------------
Updated the patch for tests. Looks like something (line endings?) is making git
not like the original patches.
+1 for the fix; is it easy to add a regression unit test for this?
TestWorkloadManager has various tests.
> Wrong argument in the WorkloadManager.resetAndQueryKill()
> ---------------------------------------------------------
>
> Key: HIVE-18492
> URL: https://issues.apache.org/jira/browse/HIVE-18492
> Project: Hive
> Issue Type: Bug
> Reporter: Oleg Danilov
> Assignee: Oleg Danilov
> Priority: Trivial
> Attachments: HIVE-18492.03.patch, HIVE-18492.2.patch, HIVE-18492.patch
>
>
> Caused by HIVE-18088, [~prasanth_j], could you please check this?
> {code:java}
> private void resetAndQueueKill(Map<WmTezSession, KillQueryContext>
> toKillQuery,
> KillQueryContext killQueryContext, Map<WmTezSession, GetRequest> toReuse) {
> WmTezSession toKill = killQueryContext.session;
> ...
> if (poolState != null) {
> poolState.getSessions().remove(toKill);
> poolState.getInitializingSessions().remove(toKill);
> ...
> {code}
> getInitializingSessions() returns List of SessionInitContext, so toKill
> definitely can't be in this list and therefore no needs to remove it.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
