[ https://issues.apache.org/jira/browse/HIVE-18524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341934#comment-16341934 ]
Hive QA commented on HIVE-18524: -------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 33s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 6m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 59s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 22s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 50s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 50s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 39s{color} | {color:red} ql: The patch generated 4 new + 39 unchanged - 10 fixed = 43 total (was 49) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 42s{color} | {color:red} root: The patch generated 4 new + 39 unchanged - 10 fixed = 43 total (was 49) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch 2 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 7s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 11s{color} | {color:red} The patch generated 6 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 45m 56s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh | | git revision | master / 905d84e | | Default Java | 1.8.0_111 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-8860/yetus/diff-checkstyle-ql.txt | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-8860/yetus/diff-checkstyle-root.txt | | whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-8860/yetus/whitespace-tabs.txt | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-8860/yetus/patch-asflicense-problems.txt | | modules | C: ql . itests U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-8860/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Vectorization: Execution failure related to non-standard embedding of > IfExprConditionalFilter inside VectorUDFAdaptor (Revert HIVE-17139) > ----------------------------------------------------------------------------------------------------------------------------------------- > > Key: HIVE-18524 > URL: https://issues.apache.org/jira/browse/HIVE-18524 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 3.0.0 > Reporter: Matt McCline > Assignee: Matt McCline > Priority: Critical > Fix For: 3.0.0 > > Attachments: HIVE-18524.01.patch > > > {noformat} > insert overwrite table insert_10_1 > select cast(gpa as float), > age, > IF(age>40,cast('2011-01-01 01:01:01' as timestamp),NULL), > IF(LENGTH(name)>10,cast(name as binary),NULL) > from studentnull10k > vectorizationSchemaColumns: [0:name:string, 1:age:int, 2:gpa:double] > ExprNodeDescs: > UDFToFloat(gpa) (type: float), > age (type: int), > if((age > 40), 2011-01-01 01:01:01.0, null) (type: timestamp), > if((length(name) > 10), CAST( name AS BINARY), null) (type: binary) > selectExpressions: > VectorUDFAdaptor(if((age > 40), 2011-01-01 01:01:01.0, null)) > (children: LongColGreaterLongScalar(col 1:int, val 40) -> 4:boolean) > -> 5:timestamp, > VectorUDFAdaptor(if((length(name) > 10), CAST( name AS BINARY), null)) > (children: LongColGreaterLongScalar(col 4:int, val 10)(children: > StringLength(col 0:string) -> 4:int) -> 6:boolean, > VectorUDFAdaptor(CAST( name AS BINARY)) -> 7:binary) -> 8:binary > {noformat} > *// Notice there is no vector expression shown for the last IF stmt.* It has > been magically embedded inside the VectorUDFAdaptor object... > Execution results in this call stack. > {nocode} > Caused by: java.lang.NullPointerException > at java.util.Arrays.copyOfRange(Arrays.java:3521) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpressionWriterFactory$9.writeValue(VectorExpressionWriterFactory.java:1101) > at > org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpressionWriterFactory$VectorExpressionWriterBytes.writeValue(VectorExpressionWriterFactory.java:343) > at > org.apache.hadoop.hive.ql.exec.vector.udf.VectorUDFArgDesc.getDeferredJavaObject(VectorUDFArgDesc.java:123) > at > org.apache.hadoop.hive.ql.exec.vector.udf.VectorUDFAdaptor.setResult(VectorUDFAdaptor.java:211) > at > org.apache.hadoop.hive.ql.exec.vector.udf.VectorUDFAdaptor.evaluate(VectorUDFAdaptor.java:177) > at > org.apache.hadoop.hive.ql.exec.vector.VectorSelectOperator.process(VectorSelectOperator.java:145) > ... 22 more > {nocode} > Change is due to: > HIVE-17139: Conditional expressions optimization: skip the expression > evaluation if the condition is not satisfied for vectorization engine. (Jia > Ke, reviewed by Ferdinand Xu) > Embedding a raw vector expression outside of VectorizationContext is quite > non-standard and evidently buggy. > [~Ferd] [~Ke Jia] I am inclined to revert this change. Comments? CC: > [~ashutoshc] [~hagleitn] -- This message was sent by Atlassian JIRA (v7.6.3#76005)