[ 
https://issues.apache.org/jira/browse/HIVE-16605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351642#comment-16351642
 ] 

Hive QA commented on HIVE-16605:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12909123/HIVE-16605.4.patch

{color:green}SUCCESS:{color} +1 due to 10 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 69 failed/errored test(s), 12978 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries]
 (batchId=240)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2] 
(batchId=49)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mapjoin_hook] 
(batchId=13)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[mm_cttas] (batchId=47)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=36)
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[row__id] (batchId=79)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl]
 (batchId=175)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb] 
(batchId=152)
org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[mm_cttas] 
(batchId=150)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1]
 (batchId=172)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata]
 (batchId=167)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid] 
(batchId=171)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast]
 (batchId=162)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[mergejoin] 
(batchId=166)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[resourceplan]
 (batchId=164)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] 
(batchId=161)
org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorization_input_format_excludes]
 (batchId=163)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5] 
(batchId=122)
org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut 
(batchId=221)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testAlterPartition
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testAlterTable 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testAlterTableCascade
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testAlterViewParititon
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testColumnStatistics
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testComplexTable 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testComplexTypeApi
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testConcurrentMetastores
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testDBLocationChange
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testDBOwner 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testDBOwnerChange 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testDatabase 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testDatabaseLocation
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testDatabaseLocationWithPermissionProblems
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testDropTable 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testFilterLastPartition
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testFilterSinglePartition
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testFunctionWithResources
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testGetConfigValue
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testGetMetastoreUuid
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testGetSchemaWithNoClassDefFoundError
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testGetTableObjects
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testGetUUIDInParallel
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testJDOPersistanceManagerCleanup
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testListPartitionNames
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testListPartitions
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testListPartitionsWihtLimitEnabled
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testNameMethods 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testPartition 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testPartitionFilter
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testRenamePartition
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testRetriableClientWithConnLifetime
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testSimpleFunction
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testSimpleTable 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testSimpleTypeApi 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testStatsFastTrivial
 (batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testSynchronized 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testTableDatabase 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testTableFilter 
(batchId=207)
org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testValidateTableCols
 (batchId=207)
org.apache.hadoop.hive.metastore.client.TestTablesGetExists.testGetAllTablesCaseInsensitive[Embedded]
 (batchId=206)
org.apache.hadoop.hive.ql.TestTxnNoBuckets.testCTAS (batchId=280)
org.apache.hadoop.hive.ql.TestTxnNoBucketsVectorized.testCTAS (batchId=280)
org.apache.hadoop.hive.ql.exec.TestOperators.testNoConditionalTaskSizeForLlap 
(batchId=282)
org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=256)
org.apache.hadoop.hive.ql.parse.TestExportImport.org.apache.hadoop.hive.ql.parse.TestExportImport
 (batchId=228)
org.apache.hive.beeline.cli.TestHiveCli.testNoErrorDB (batchId=188)
org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=234)
org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=234)
org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=234)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/9007/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/9007/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-9007/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 69 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12909123 - PreCommit-HIVE-Build

> Enforce NOT NULL constraints
> ----------------------------
>
>                 Key: HIVE-16605
>                 URL: https://issues.apache.org/jira/browse/HIVE-16605
>             Project: Hive
>          Issue Type: New Feature
>    Affects Versions: 3.0.0
>            Reporter: Carter Shanklin
>            Assignee: Vineet Garg
>            Priority: Major
>         Attachments: HIVE-16605.1.patch, HIVE-16605.2.patch, 
> HIVE-16605.3.patch, HIVE-16605.4.patch
>
>
> Since NOT NULL is so common it would be great to have tables start to enforce 
> that.
> [~ekoifman] described a possible approach in HIVE-16575:
> {quote}
> One way to enforce not null constraint is to have the optimizer add 
> enforce_not_null UDF which throws if it sees a NULL, otherwise it's pass 
> through.
> So if 'b' has not null constraint,
> Insert into T select a,b,c... would become
> Insert into T select a, enforce_not_null(b), c.....
> This would work for any table type.
> {quote}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to