[ 
https://issues.apache.org/jira/browse/HIVE-18359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358907#comment-16358907
 ] 

Prasanth Jayachandran commented on HIVE-18359:
----------------------------------------------

Minor golden file updates for 3 test failures. Most other failures cannot be 
reproduced locally or unrelated to this patch. 

> Extend grouping set limits from int to long
> -------------------------------------------
>
>                 Key: HIVE-18359
>                 URL: https://issues.apache.org/jira/browse/HIVE-18359
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>            Priority: Major
>         Attachments: HIVE-18359.1.patch, HIVE-18359.10.patch, 
> HIVE-18359.11.patch, HIVE-18359.11.patch, HIVE-18359.12.patch, 
> HIVE-18359.2.patch, HIVE-18359.3.patch, HIVE-18359.4.patch, 
> HIVE-18359.5.patch, HIVE-18359.6.patch, HIVE-18359.7.patch, 
> HIVE-18359.8.patch, HIVE-18359.9.patch
>
>
> Grouping sets is broken for >32 columns because of usage of Int for bitmap 
> (also GROUPING__ID virtual column). This assumption breaks grouping 
> sets/rollups/cube when number of participating aggregation columns is >32. 
> The easier fix would be extend it to Long for now. The correct fix would be 
> to use BitSets everywhere but that would require GROUPING__ID column type to 
> binary which will make predicates on GROUPING__ID difficult to deal with. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to