Peter Vary commented on HIVE-18456:

Hi [~asherman],

Thanks for taking care of this test too!

Just one little nit - we should use either a variable, or a constant for table 
 * Once you use a variable:
stmt.execute("create view " + view + " as select * from " + table);{code}

 * Other places you use a constant. For example:
extendedViewDescription.contains("viewOriginalText:select * from 

I would prefer to stick with one of the methods.
 Otherwise it looks good to me.


> Add some tests for HIVE-18367 to check that the table information contains 
> the query correctly
> ----------------------------------------------------------------------------------------------
>                 Key: HIVE-18456
>                 URL: https://issues.apache.org/jira/browse/HIVE-18456
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Andrew Sherman
>            Assignee: Andrew Sherman
>            Priority: Major
>         Attachments: HIVE-18456.1.patch, HIVE-18456.2.patch
> This cannot be tested with a CliDriver test so add a java test to check the 
> output of 'describe extended', which is changed by HIVE-18367 

This message was sent by Atlassian JIRA

Reply via email to