[
https://issues.apache.org/jira/browse/HIVE-18456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16360537#comment-16360537
]
Peter Vary commented on HIVE-18456:
-----------------------------------
Hi [~asherman],
Thanks for taking care of this test too!
Just one little nit - we should use either a variable, or a constant for table
names:
* Once you use a variable:
{code:java}
stmt.execute("create view " + view + " as select * from " + table);{code}
* Other places you use a constant. For example:
{code:java}
extendedViewDescription.contains("viewOriginalText:select * from
testDescribe"));{code}
I would prefer to stick with one of the methods.
Otherwise it looks good to me.
Thanks,
Peter
> Add some tests for HIVE-18367 to check that the table information contains
> the query correctly
> ----------------------------------------------------------------------------------------------
>
> Key: HIVE-18456
> URL: https://issues.apache.org/jira/browse/HIVE-18456
> Project: Hive
> Issue Type: Bug
> Reporter: Andrew Sherman
> Assignee: Andrew Sherman
> Priority: Major
> Attachments: HIVE-18456.1.patch, HIVE-18456.2.patch
>
>
> This cannot be tested with a CliDriver test so add a java test to check the
> output of 'describe extended', which is changed by HIVE-18367
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
