[ 
https://issues.apache.org/jira/browse/HIVE-18708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364823#comment-16364823
 ] 

Prasanth Jayachandran commented on HIVE-18708:
----------------------------------------------

nits to reduce java clutter:
{code}
for (Iterator<ImmutablePair<Operator<? extends OperatorDesc>, Operator<? 
extends OperatorDesc>>> iterator =
value.iterator(); iterator.hasNext();) {
ImmutablePair<Operator<? extends OperatorDesc>, Operator<? extends 
OperatorDesc>> swap =
iterator.next(); 
{code}
can be replaced with generic forloop which effectively compiles to iterator. 

Also, right hand side types for 'delayedFixups' and 'value' can be replaced 
with <> (inferred from lhs). 

Both nits can be updated on commit. +1, pending tests.



> Vectorization: Delay out-of-tree fixups till whole work is vectorized
> ---------------------------------------------------------------------
>
>                 Key: HIVE-18708
>                 URL: https://issues.apache.org/jira/browse/HIVE-18708
>             Project: Hive
>          Issue Type: Bug
>          Components: Vectorization
>    Affects Versions: 3.0.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>            Priority: Major
>         Attachments: HIVE-18708.1.patch, HIVE-18708.2.patch
>
>
> The vectorization validation codepath should treat the existing operator tree 
> as immutable, so that the VectorizerCannotVectorizeException does not have to 
> undo any changes to the operator tree when caught.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to