[ 
https://issues.apache.org/jira/browse/HIVE-18746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370730#comment-16370730
 ] 

Szehon Ho commented on HIVE-18746:
----------------------------------

Patch looks good but the related test seems to be failing, can you take a look?

> add_months should validate the date first
> -----------------------------------------
>
>                 Key: HIVE-18746
>                 URL: https://issues.apache.org/jira/browse/HIVE-18746
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Subhasis Gorai
>            Assignee: Kryvenko Igor
>            Priority: Minor
>         Attachments: HIVE-18746.patch
>
>
> hive (sbg_hvc_ods)> select add_months('2017-02-28', 1);
> OK
> _c0
> 2017-03-31
> Time taken: 0.107 seconds, Fetched: 1 row(s)
> hive (sbg_hvc_ods)> select add_months('2017-02-29', 1);
> OK
> _c0
> 2017-04-01
> Time taken: 0.084 seconds, Fetched: 1 row(s)
> hive (sbg_hvc_ods)>
>  
> '2017-02-29' is an invalid date.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to