[ 
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373700#comment-16373700
 ] 

Vihang Karajgaonkar commented on HIVE-17580:
--------------------------------------------

Hi [~alangates] the latest patch attached here moves the TypeInfos (with much 
less disruption than previously thought) to standalone-metastore like we 
discussed last time. This would remove a lot of duplicate code from the 
previous patch and also I think is more sensible from design point of view. The 
only class which caused lot of changes to other files was {{Category}} enum 
from ObjectInspector. I did not understand why it was defined in 
ObjectInspector in the first place since it looks more related to TypeInfo than 
ObjectInspector to me. Rest of the changes are not too complex. I have tried to 
explain the reasoning behind some of weird changes in code via code comments 
and above. Also, added a unit test in metastore to test avro schemas and ran 
the existing q tests for avro before submitting the patch. Can you please take 
a look?

cc [~ashutoshc] [~sershe] [~owen.omalley] [~akolb]

> Remove dependency of get_fields_with_environment_context API to serde
> ---------------------------------------------------------------------
>
>                 Key: HIVE-17580
>                 URL: https://issues.apache.org/jira/browse/HIVE-17580
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Standalone Metastore
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-17580.003-standalone-metastore.patch, 
> HIVE-17580.04-standalone-metastore.patch, 
> HIVE-17580.05-standalone-metastore.patch, 
> HIVE-17580.06-standalone-metastore.patch
>
>
> {{get_fields_with_environment_context}} metastore API uses {{Deserializer}} 
> class to access the fields metadata for the cases where it is stored along 
> with the data files (avro tables). The problem is Deserializer classes is 
> defined in hive-serde module and in order to make metastore independent of 
> Hive we will have to remove this dependency (atleast we should change it to 
> runtime dependency instead of compile time).
> The other option is investigate if we can use SearchArgument to provide this 
> functionality.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to