[ 
https://issues.apache.org/jira/browse/HIVE-17580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381124#comment-16381124
 ] 

Vihang Karajgaonkar commented on HIVE-17580:
--------------------------------------------

Thanks [~owen.omalley] for taking a look.

bq. I'm not happy about ObjectInspector moving into storage-api.

Can you please give reasons why you think its not a good idea to move just the 
interface to storage-api?

bq. If you need the Category enum, I'd suggest you duplicate it and extend the 
ObjectInspector.Category with a mapping to the storage-api Category.

Just to confirm I understand what you are suggesting above. Lets say we create 
a duplicate Category enum called {{MetastoreTypeCategory}} and define it in 
metastore. We can add a methods in ObjectInspector.Category to map one to 
another. How does that help with the {{getCategory}} method in TypeInfo since 
it returns ObjectInspector.Category? It will still not compile. Are you also 
suggesting modify that method to return {{MetastoreTypeCategory}}? Not only 
that would be backwards incompatible for anyone outside hive using TypeInfo, it 
would also need modification all over the code (eg. If I find usages of this 
method in the code I see 221 usages across multiple modules) Its doable but is 
it worth it?

> Remove dependency of get_fields_with_environment_context API to serde
> ---------------------------------------------------------------------
>
>                 Key: HIVE-17580
>                 URL: https://issues.apache.org/jira/browse/HIVE-17580
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Standalone Metastore
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: HIVE-17580.003-standalone-metastore.patch, 
> HIVE-17580.04-standalone-metastore.patch, 
> HIVE-17580.05-standalone-metastore.patch, 
> HIVE-17580.06-standalone-metastore.patch, 
> HIVE-17580.07-standalone-metastore.patch, 
> HIVE-17580.08-standalone-metastore.patch, 
> HIVE-17580.09-standalone-metastore.patch, 
> HIVE-17580.092-standalone-metastore.patch
>
>
> {{get_fields_with_environment_context}} metastore API uses {{Deserializer}} 
> class to access the fields metadata for the cases where it is stored along 
> with the data files (avro tables). The problem is Deserializer classes is 
> defined in hive-serde module and in order to make metastore independent of 
> Hive we will have to remove this dependency (atleast we should change it to 
> runtime dependency instead of compile time).
> The other option is investigate if we can use SearchArgument to provide this 
> functionality.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to