[ 
https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16390680#comment-16390680
 ] 

Sahil Takiar commented on HIVE-18883:
-------------------------------------

Thanks for the tip [~pvary]! Helped a lot. What do you think of my patch? It 
works when running YETUS locally as described in the wiki you linked above.

Implementation:
* This patch just curls the distribution and sets {{FINDBUGS_HOME}} inside the 
{{yetus-wrapper.sh}} file
* The code to download the FindBugs distribution is based on the commands to 
download the YETUS distribution (downloads FindBugs to the same place as YETUS 
is downloaded), with a few modifications
* One thing I couldn't understand is that when I run {{yetus-wrapper.sh}} 
locally it downloads everything to the {{patchprocess}} directory, but I 
couldn't find the corresponding directory on the ptest server. Any idea where 
it is? Does the YETUS distribution get downloaded for each YETUS run? In which 
case FindBugs will be downloaded each time too. 

Some other notes while working on this:
* It seems most of the other Apache projects that use YETUS use some sort of 
YETUS-Docker integration that downloads the FindBugs dependency
* Ideally, we would do the same thing and we could just do {{apt-get install 
findbugs}} and set the {{FINDBUGS_HOME}} appropriately (looks like HBase 
manually curls the FindBugs installation)
* It looks like each pre-commit run of these Apache projects builds the 
Dockerfile, so it downloads the findbugs distro during each run
* So, overall, I think we are still inline with what other projects are doing, 
we just don't use docker (e.g. we download the distribution during each 
pre-commit run)

> Add findbugs to yetus pre-commit checks
> ---------------------------------------
>
>                 Key: HIVE-18883
>                 URL: https://issues.apache.org/jira/browse/HIVE-18883
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>         Attachments: HIVE-18883.1.patch
>
>
> We should enable FindBugs for our YETUS pre-commit checks, this will help 
> overall code quality and should decrease the overall number of bugs in Hive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to