[ 
https://issues.apache.org/jira/browse/HIVE-18898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406892#comment-16406892
 ] 

Sahil Takiar commented on HIVE-18898:
-------------------------------------

Yeah, I think this patch looks good. +1 from me.

 Agree we don't want to make backwards incompatible changes to the API here, so 
adding the checks in the HMS Client makes sense.

> Fix NPEs in HiveMetastore.dropPartition method
> ----------------------------------------------
>
>                 Key: HIVE-18898
>                 URL: https://issues.apache.org/jira/browse/HIVE-18898
>             Project: Hive
>          Issue Type: Bug
>          Components: Metastore
>            Reporter: Marta Kuczora
>            Assignee: Marta Kuczora
>            Priority: Minor
>         Attachments: HIVE-18898.1.patch, HIVE-18898.2.patch
>
>
> The TestDropPartitions tests revealed that NPE is thrown if the 
> dropPartition(String db_name, String tbl_name, List<String> part_vals, 
> PartitionDropOptions options) method is called with null options and with a 
> part_vals list which contains null elements.
> Example: NPE is thrown in the following test cases
>  * testDropPartitionNullPartDropOptions
>  * testDropPartitionNullVal



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to