[
https://issues.apache.org/jira/browse/HIVE-18716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422809#comment-16422809
]
Gergely Hajós commented on HIVE-18716:
--------------------------------------
[~kgyrtkirk] Thank you for the review!
> Delete unnecessary parameters from TaskFactory
> ----------------------------------------------
>
> Key: HIVE-18716
> URL: https://issues.apache.org/jira/browse/HIVE-18716
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Affects Versions: 3.0.0
> Reporter: Gergely Hajós
> Assignee: Gergely Hajós
> Priority: Trivial
> Fix For: 3.0.0
>
> Attachments: HIVE-18716.1.patch, HIVE-18716.2.patch,
> HIVE-18716.3.patch, HIVE-18716.4.patch, HIVE-18716.5.patch
>
>
> * In _TaskFactory class conf_ parameter is not used here
> {code:java}
> public static <T extends Serializable> Task<T> get(Class<T> workClass,
> HiveConf conf)
> {code}
> * _get_ functions never called with vararg parameter _Task<? extends
> Serializable>... tasklist_
> * the following version of _get_ is always called with _setConf_ true from
> outside of _TaskFactory_ class
> {code:java}
> public static <T extends Serializable> Task<T> get(T work, HiveConf conf,
> boolean setConf, Task<? extends Serializable>... tasklist)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
