[ 
https://issues.apache.org/jira/browse/HIVE-18883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423798#comment-16423798
 ] 

Peter Vary commented on HIVE-18883:
-----------------------------------

[~stakiar]: The patch contains an extra file \{{HIVE-18883.2.patch}}. Otherwise 
+1. I can remove the extra file if you want. I do not know how strict are we 
about this.

Thanks for taking care of this!!

> Add findbugs to yetus pre-commit checks
> ---------------------------------------
>
>                 Key: HIVE-18883
>                 URL: https://issues.apache.org/jira/browse/HIVE-18883
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Testing Infrastructure
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>            Priority: Major
>         Attachments: HIVE-18883.1.patch, HIVE-18883.2.patch
>
>
> We should enable FindBugs for our YETUS pre-commit checks, this will help 
> overall code quality and should decrease the overall number of bugs in Hive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to