[
https://issues.apache.org/jira/browse/HIVE-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427555#comment-16427555
]
Hive QA commented on HIVE-12192:
--------------------------------
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12894251/HIVE-12192.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/10020/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10020/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10020/
Messages:
{noformat}
**** This message was trimmed, see log for full details ****
error: patch failed:
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java:22
Falling back to three-way merge...
Applied patch to
'ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java'
with conflicts.
error: patch failed:
serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java:20
Falling back to three-way merge...
Applied patch to
'serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java' with
conflicts.
error: patch failed:
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java:23
Falling back to three-way merge...
Applied patch to
'serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java'
cleanly.
error: patch failed:
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.java:285
Falling back to three-way merge...
Applied patch to
'storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.java'
with conflicts.
Going to apply patch with: git apply -p0
error: patch failed:
common/src/java/org/apache/hive/common/util/TimestampParser.java:18
Falling back to three-way merge...
Applied patch to
'common/src/java/org/apache/hive/common/util/TimestampParser.java' with
conflicts.
error: patch failed:
druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java:510
Falling back to three-way merge...
Applied patch to
'druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java'
with conflicts.
error: patch failed:
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java:348
Falling back to three-way merge...
Applied patch to
'hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java'
with conflicts.
error: patch failed:
hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/JsonSerDe.java:21
Falling back to three-way merge...
Applied patch to
'hcatalog/core/src/main/java/org/apache/hive/hcatalog/data/JsonSerDe.java'
cleanly.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/DateColumnArithmeticTimestampColumn.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/DateColumnArithmeticTimestampColumn.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/DateColumnArithmeticTimestampScalar.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/DateColumnArithmeticTimestampScalar.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/DateScalarArithmeticTimestampColumn.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/DateScalarArithmeticTimestampColumn.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/IntervalYearMonthColumnArithmeticTimestampScalar.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/IntervalYearMonthColumnArithmeticTimestampScalar.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/IntervalYearMonthScalarArithmeticTimestampColumn.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/IntervalYearMonthScalarArithmeticTimestampColumn.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/LongDoubleColumnCompareTimestampScalar.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/LongDoubleColumnCompareTimestampScalar.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticDateColumn.txt:47
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticDateColumn.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticDateScalar.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticDateScalar.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticTimestampScalar.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticTimestampScalar.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnCompareTimestampScalar.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnCompareTimestampScalar.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticDateColumn.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticDateColumn.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticIntervalYearMonthColumn.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticIntervalYearMonthColumn.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticTimestampColumn.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticTimestampColumn.txt'
with conflicts.
error: patch failed:
ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarCompareTimestampColumn.txt:18
Falling back to three-way merge...
Applied patch to
'ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarCompareTimestampColumn.txt'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java:20
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java:41
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedBatchUtil.java:20
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedBatchUtil.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java:19
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastLongToTimestamp.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastLongToTimestamp.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastMillisecondsLongToTimestamp.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastMillisecondsLongToTimestamp.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ConstantVectorExpression.java:19
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ConstantVectorExpression.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateColSubtractDateColumn.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateColSubtractDateColumn.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateColSubtractDateScalar.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateColSubtractDateScalar.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateScalarSubtractDateColumn.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateScalarSubtractDateColumn.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DynamicValueVectorExpression.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DynamicValueVectorExpression.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprTimestampColumnScalarBase.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprTimestampColumnScalarBase.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprTimestampScalarColumnBase.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprTimestampScalarColumnBase.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriterFactory.java:57
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpressionWriterFactory.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFUnixTimeStampTimestamp.java:30
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFUnixTimeStampTimestamp.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/VectorPTFOperator.java:44
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/exec/vector/ptf/VectorPTFOperator.java'
cleanly.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedPrimitiveColumnReader.java:44
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedPrimitiveColumnReader.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java:20
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java' with
conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java:17
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java'
with conflicts.
error: patch failed:
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUnixTimeStamp.java:18
Falling back to three-way merge...
Applied patch to
'ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUnixTimeStamp.java'
with conflicts.
error: patch failed:
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorFilterExpressions.java:22
Falling back to three-way merge...
Applied patch to
'ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorFilterExpressions.java'
with conflicts.
error: patch failed:
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorGenericDateExpressions.java:444
Falling back to three-way merge...
Applied patch to
'ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorGenericDateExpressions.java'
with conflicts.
error: patch failed:
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorMathFunctions.java:19
Falling back to three-way merge...
Applied patch to
'ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorMathFunctions.java'
with conflicts.
error: patch failed:
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTimestampExpressions.java:48
Falling back to three-way merge...
Applied patch to
'ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTimestampExpressions.java'
with conflicts.
error: patch failed:
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java:22
Falling back to three-way merge...
Applied patch to
'ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java'
with conflicts.
/data/hiveptest/working/scratch/build.patch:4508: new blank line at EOF.
+
error: patch failed:
serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java:20
Falling back to three-way merge...
Applied patch to
'serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java' with
conflicts.
error: patch failed:
serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java:23
Falling back to three-way merge...
Applied patch to
'serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java'
cleanly.
error: patch failed:
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.java:285
Falling back to three-way merge...
Applied patch to
'storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.java'
with conflicts.
U common/src/java/org/apache/hive/common/util/TimestampParser.java
U druid-handler/src/java/org/apache/hadoop/hive/druid/serde/DruidSerDe.java
U
hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java
U
ql/src/gen/vectorization/ExpressionTemplates/DateColumnArithmeticTimestampColumn.txt
U
ql/src/gen/vectorization/ExpressionTemplates/DateColumnArithmeticTimestampScalar.txt
U
ql/src/gen/vectorization/ExpressionTemplates/DateScalarArithmeticTimestampColumn.txt
U
ql/src/gen/vectorization/ExpressionTemplates/IntervalYearMonthColumnArithmeticTimestampScalar.txt
U
ql/src/gen/vectorization/ExpressionTemplates/IntervalYearMonthScalarArithmeticTimestampColumn.txt
U
ql/src/gen/vectorization/ExpressionTemplates/LongDoubleColumnCompareTimestampScalar.txt
U
ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticDateColumn.txt
U
ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticDateScalar.txt
U
ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnArithmeticTimestampScalar.txt
U
ql/src/gen/vectorization/ExpressionTemplates/TimestampColumnCompareTimestampScalar.txt
U
ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticDateColumn.txt
U
ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticIntervalYearMonthColumn.txt
U
ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarArithmeticTimestampColumn.txt
U
ql/src/gen/vectorization/ExpressionTemplates/TimestampScalarCompareTimestampColumn.txt
U ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorHashKeyWrapper.java
U ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedBatchUtil.java
U ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastLongToTimestamp.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastMillisecondsLongToTimestamp.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ConstantVectorExpression.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateColSubtractDateColumn.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateColSubtractDateScalar.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DateScalarSubtractDateColumn.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/DynamicValueVectorExpression.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprTimestampColumnScalarBase.java
U
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IfExprTimestampScalarColumnBase.java
U
ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedPrimitiveColumnReader.java
U ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
U ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java
U
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUnixTimeStamp.java
U
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorFilterExpressions.java
U
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorGenericDateExpressions.java
U
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorMathFunctions.java
U
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTimestampExpressions.java
U
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorTypeCasts.java
U serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java
U
storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.java
warning: 1 line adds whitespace errors.
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12894251 - PreCommit-HIVE-Build
> Hive should carry out timestamp computations in UTC
> ---------------------------------------------------
>
> Key: HIVE-12192
> URL: https://issues.apache.org/jira/browse/HIVE-12192
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Ryan Blue
> Assignee: Jesus Camacho Rodriguez
> Priority: Major
> Labels: timestamp
> Attachments: HIVE-12192.patch
>
>
> Hive currently uses the "local" time of a java.sql.Timestamp to represent the
> SQL data type TIMESTAMP WITHOUT TIME ZONE. The purpose is to be able to use
> {{Timestamp#getYear()}} and similar methods to implement SQL functions like
> {{year}}.
> When the SQL session's time zone is a DST zone, such as America/Los_Angeles
> that alternates between PST and PDT, there are times that cannot be
> represented because the effective zone skips them.
> {code}
> hive> select TIMESTAMP '2015-03-08 02:10:00.101';
> 2015-03-08 03:10:00.101
> {code}
> Using UTC instead of the SQL session time zone as the underlying zone for a
> java.sql.Timestamp avoids this bug, while still returning correct values for
> {{getYear}} etc. Using UTC as the convenience representation (timestamp
> without time zone has no real zone) would make timestamp calculations more
> consistent and avoid similar problems in the future.
> Notably, this would break the {{unix_timestamp}} UDF that specifies the
> result is with respect to ["the default timezone and default
> locale"|https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-DateFunctions].
> That function would need to be updated to use the
> {{System.getProperty("user.timezone")}} zone.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
