Marta Kuczora commented on HIVE-19119:

Hi [~alangates],
I would have a question for you regarding the null check in the 
HiveMetaStore.append_partition_with_environment_context method. I saw that in 
[HIVE-18755|https://issues.apache.org/jira/browse/HIVE-18755] you changed the 
expected exception type from MetaException to InvalidObjectException in the 
TestAppendPartitions.testAppendPartitionNullPartValues and 
TestAppendPartitions.testAppendPartitionEmptyPartValues tests. But the null 
check in the append_partition_with_environment_context still throws 
if (part_vals == null || part_vals.isEmpty()) {
  throw new MetaException("The partition values must not be null.");
I'd like to fix this test, but first I'd like to verify this with you. Which 
would be the preferred exception type to throw if the null check fails, 
InvalidObjectException or MetaException?

> Fix the TestAppendPartitions tests which are failing in the pre-commit runs
> ---------------------------------------------------------------------------
>                 Key: HIVE-19119
>                 URL: https://issues.apache.org/jira/browse/HIVE-19119
>             Project: Hive
>          Issue Type: Bug
>          Components: Test
>            Reporter: Marta Kuczora
>            Assignee: Marta Kuczora
>            Priority: Minor
>         Attachments: HIVE-19119.1.patch
> The test got fixed in 
> [HIVE-19060|https://issues.apache.org/jira/browse/HIVE-19060], but the fix 
> got overwritten by an other commit, so  the testAppendPartitionNullPartValues 
> and testAppendPartitionEmptyPartValues test cases are failing again.

This message was sent by Atlassian JIRA

Reply via email to