[ 
https://issues.apache.org/jira/browse/HIVE-19126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428648#comment-16428648
 ] 

Thejas M Nair commented on HIVE-19126:
--------------------------------------


Thanks for the patch.
Can you please add a reviewboard link or github pull request ?

Some initial comments -
 * Can you also add SizeValidator to standalone metastore (similar to 
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/conf/TimeValidator)
 and use it for this config ? That way size can be specified in GB.
 * Many files have only changes in import sequence, can you please revert those 
changes ?


> CachedStore: Use memory estimation to limit cache size during prewarm
> ---------------------------------------------------------------------
>
>                 Key: HIVE-19126
>                 URL: https://issues.apache.org/jira/browse/HIVE-19126
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Metastore
>    Affects Versions: 3.0.0
>            Reporter: Vaibhav Gumashta
>            Assignee: Vaibhav Gumashta
>            Priority: Major
>         Attachments: HIVE-19126.1.patch
>
>
> We can rely on 
> https://github.com/apache/hive/blob/master/llap-server/src/java/org/apache/hadoop/hive/llap/IncrementalObjectSizeEstimator.java
>  to estimate memory of SharedCache. This jira addresses the size estimation 
> during prewarm, so that we can stop when we hit the memory limit. In a 
> follow-up jira, we will work on estimation/eviction after prewarm is 
> complete, so that we can keep the frequently used tables and their partitions 
> in cache.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to