Jason Dere commented on HIVE-17645:

[~sershe] brought this to my attention as well, plus the fact that the 
sessionstate txn manager is being called in some of the semantic analyzer code:
    - SemanticAnalyzer.genFileSinkPlan()
    - ReplicationSemanticAnalyzer.analyzeReplLoad()
    - LoadSemanticAnalyzer.analyzeExternal()
    - ImportSemanticAnalyzer.prepareImport()
    - DDLSemanticAnalyzer.handleTransactionalTable()

As Sergey mentions earlier, most of these (with the exception of 
genFileSinkPlan) are probably ok since they are related t DDL/import/repl, 
which would not happen for HIVE-17482. But probably good to fix these so that 
all examples of getting the txn manager use the same call.

> MM tables patch conflicts with HIVE-17482 (Spark/Acid integration)
> ------------------------------------------------------------------
>                 Key: HIVE-17645
>                 URL: https://issues.apache.org/jira/browse/HIVE-17645
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>            Priority: Major
>              Labels: mm-gap-2
> MM code introduces 
> {noformat}
> HiveTxnManager txnManager = SessionState.get().getTxnMgr()
> {noformat}
> in a number of places (e.g _DDLTask.generateAddMmTasks(Table tbl)_).  
> HIVE-17482 adds a mode where a TransactionManager not associated with the 
> session should be used.  This will need to be addressed.

This message was sent by Atlassian JIRA

Reply via email to