[ 
https://issues.apache.org/jira/browse/HIVE-18857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429353#comment-16429353
 ] 

Hive QA commented on HIVE-18857:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12917778/HIVE-18857.1.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/10052/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/10052/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-10052/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2018-04-07 13:03:01.336
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-10052/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2018-04-07 13:03:01.338
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at a316c82 HIVE-19121 : Fix HiveSchemaTool validation for databases 
that don't support schema (Miklos Gergely via Ashutosh Chauhan)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at a316c82 HIVE-19121 : Fix HiveSchemaTool validation for databases 
that don't support schema (Miklos Gergely via Ashutosh Chauhan)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2018-04-07 13:03:04.651
+ rm -rf ../yetus_PreCommit-HIVE-Build-10052
+ mkdir ../yetus_PreCommit-HIVE-Build-10052
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-10052
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-10052/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: a/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java: 
does not exist in index
Going to apply patch with: git apply -p1
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q 
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc3045356146628633020.exe, --version]
libprotoc 2.5.0
protoc-jar: executing: [/tmp/protoc3045356146628633020.exe, 
-I/data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/protobuf/org/apache/hadoop/hive/metastore,
 
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/target/generated-sources,
 
/data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator  Version 3.5.2
Output file 
/data/hiveptest/working/apache-github-source-source/standalone-metastore/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g
org/apache/hadoop/hive/metastore/parser/Filter.g
log4j:WARN No appenders could be found for logger (DataNucleus.Persistence).
log4j:WARN Please initialize the log4j system properly.
DataNucleus Enhancer (version 4.1.17) for API "JDO"
DataNucleus Enhancer completed with success for 39 classes.
ANTLR Parser Generator  Version 3.5.2
Output file 
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
org/apache/hadoop/hive/ql/parse/HiveLexer.g
Output file 
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveParser.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
org/apache/hadoop/hive/ql/parse/HiveParser.g
Output file 
/data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HintParser.java
 does not exist: must build 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HintParser.g
org/apache/hadoop/hive/ql/parse/HintParser.g
Generating vector expression code
Generating vector expression test code
Processing annotations
Annotations processed
Processing annotations
No elements to process
[ERROR] COMPILATION ERROR : 
[ERROR] 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[3157,9]
 method processDefaultConstraints in class 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer cannot be applied to given 
types;
  required: 
java.lang.String,java.lang.String,java.lang.String,org.apache.hadoop.hive.ql.parse.ASTNode,java.util.List<java.lang.String>,java.util.List<org.apache.hadoop.hive.metastore.api.SQLDefaultConstraint>,org.apache.hadoop.hive.ql.parse.ASTNode,org.antlr.runtime.TokenRewriteStream
  found: 
java.lang.String,java.lang.String,java.lang.String,org.apache.hadoop.hive.ql.parse.ASTNode,com.google.common.collect.ImmutableList<java.lang.String>,java.util.List<org.apache.hadoop.hive.metastore.api.SQLDefaultConstraint>,org.apache.hadoop.hive.ql.parse.ASTNode
  reason: actual and formal argument lists differ in length
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) 
on project hive-exec: Compilation failure
[ERROR] 
/data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:[3157,9]
 method processDefaultConstraints in class 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer cannot be applied to given 
types;
[ERROR] required: 
java.lang.String,java.lang.String,java.lang.String,org.apache.hadoop.hive.ql.parse.ASTNode,java.util.List<java.lang.String>,java.util.List<org.apache.hadoop.hive.metastore.api.SQLDefaultConstraint>,org.apache.hadoop.hive.ql.parse.ASTNode,org.antlr.runtime.TokenRewriteStream
[ERROR] found: 
java.lang.String,java.lang.String,java.lang.String,org.apache.hadoop.hive.ql.parse.ASTNode,com.google.common.collect.ImmutableList<java.lang.String>,java.util.List<org.apache.hadoop.hive.metastore.api.SQLDefaultConstraint>,org.apache.hadoop.hive.ql.parse.ASTNode
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please 
read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <goals> -rf :hive-exec
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12917778 - PreCommit-HIVE-Build

> Store default value text instead of default value expression in metastore
> -------------------------------------------------------------------------
>
>                 Key: HIVE-18857
>                 URL: https://issues.apache.org/jira/browse/HIVE-18857
>             Project: Hive
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Vineet Garg
>            Assignee: Vineet Garg
>            Priority: Major
>             Fix For: 3.0.0
>
>         Attachments: HIVE-18857.1.patch
>
>
> Currently for default value an expression is generated and serialized to 
> store in metastore. It should be improved to rather serialize the default 
> value itself instead of expression and store that in metastore. This will 
> have the following benefits:
> * It will make metastore schema upgrade safe. e.g. if a UDF function name is 
> changed hive wouldn't be able to parse back the expression for this UDF which 
> was serialized in earlier version.
> *  It will make metastore schema for default constraint hive agnostic. Other 
> databases would be able to use the value as it is.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to