[ https://issues.apache.org/jira/browse/HIVE-19141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432871#comment-16432871 ]
Igor Kryvenko commented on HIVE-19141: -------------------------------------- [~vgarg] Definitely yes. I have already starting working on it. I agree with you that Negative cli driver doesn't handle errors, and i already fixed it. Now execution doesn't fails with error. But i encountered some problem that test doesn't print {{FAILED: DataConstraintViolationError}} into output file. Workaround for it don't print this message, but in this case we have output file without error message, and i think it isn't obvious because we run Negative tests and expect some error message in output file. What do you think about it? > TestNegativeCliDriver insert_into_notnull_constraint, > insert_into_acid_notnull failing > -------------------------------------------------------------------------------------- > > Key: HIVE-19141 > URL: https://issues.apache.org/jira/browse/HIVE-19141 > Project: Hive > Issue Type: Sub-task > Reporter: Vineet Garg > Assignee: Vineet Garg > Priority: Major > Fix For: 3.0.0, 3.1.0 > > > These tests have been consistently failing for a while. I suspect HIVE-18727 > has caused these failures. HIVE-18727 changed the code to throw ERROR instead > of EXCEPTION if constraints are violated. I guess Negative cli driver doesn't > handle errors. > Following are full list of related failures: > TestNegativeCliDriver.alter_notnull_constraint_violation > TestNegativeCliDriver.insert_into_acid_notnull > TestNegativeCliDriver.insert_into_notnull_constraint > TestNegativeCliDriver.insert_multi_into_notnull > TestNegativeCliDriver.insert_overwrite_notnull_constraint > TestNegativeCliDriver.update_notnull_constraint -- This message was sent by Atlassian JIRA (v7.6.3#76005)