[ 
https://issues.apache.org/jira/browse/HIVE-17824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433595#comment-16433595
 ] 

Peter Vary commented on HIVE-17824:
-----------------------------------

This one looks good to me +1 (pending tests)
On one condition :), on a follow up jira we get rid of the expression based 
solution.
The metastore thrift interface provides the possibility to drop partitions 
based on names, so we have to add this possibility to the IMetaStoreClient 
interface too, and use this here. And probably at 
https://github.com/apache/hive/blob/master/hcatalog/webhcat/java-client/src/main/java/org/apache/hive/hcatalog/api/HCatClientHMSImpl.java#L514
 too.



> msck repair table should drop the missing partitions from metastore
> -------------------------------------------------------------------
>
>                 Key: HIVE-17824
>                 URL: https://issues.apache.org/jira/browse/HIVE-17824
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Vihang Karajgaonkar
>            Assignee: Janaki Lahorani
>            Priority: Major
>         Attachments: HIVE-17824.1.patch, HIVE-17824.2.patch, 
> HIVE-17824.3.patch
>
>
> {{msck repair table <tablename>}} is often used in environments where the new 
> partitions are loaded as directories on HDFS or S3 and users want to create 
> the missing partitions in bulk. However, currently it only supports addition 
> of missing partitions. If there are any partitions which are present in 
> metastore but not on the FileSystem, it should also delete them so that it 
> truly repairs the table metadata.
> We should be careful not to break backwards compatibility so we should either 
> introduce a new config or keyword to add support to delete unnecessary 
> partitions from the metastore. This way users who want the old behavior can 
> easily turn it off. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to