[ 
https://issues.apache.org/jira/browse/HIVE-19157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434318#comment-16434318
 ] 

slim bouguerra commented on HIVE-19157:
---------------------------------------

I have attache a second patch that has a different approach.  
[^HIVE-19157.2.patch]  In this version will check for the existence of metadata 
directory first.
If such Directory is present on the file system then it must have data to load 
thus the second list should return valid file names.
if it is absent then that means there is nothing to load.


> Assert that Insert into Druid Table fails if the publishing of metadata by 
> HS2 fails
> ------------------------------------------------------------------------------------
>
>                 Key: HIVE-19157
>                 URL: https://issues.apache.org/jira/browse/HIVE-19157
>             Project: Hive
>          Issue Type: Bug
>            Reporter: slim bouguerra
>            Assignee: slim bouguerra
>            Priority: Major
>         Attachments: HIVE-19157.2.patch, HIVE-19157.patch
>
>
> The usual work flow of loading Data into Druid relies on the fact that HS2 is 
> able to load Segments metadata from HDFS that are produced by LLAP/TEZ works.
> In some cases where HS2 is not able to perform `ls` on the HDFS path the 
> insert into query will return success and will not insert any data.
> This bug was introduced at function {code} 
> org.apache.hadoop.hive.druid.DruidStorageHandlerUtils#getCreatedSegments{code}
>  
> when we added feature to allow create empty tables.
> {code}
>  try {
>       fss = fs.listStatus(taskDir);
>     } catch (FileNotFoundException e) {
>       // This is a CREATE TABLE statement or query executed for CTAS/INSERT
>       // did not produce any result. We do not need to do anything, this is
>       // expected behavior.
>       return publishedSegmentsBuilder.build();
>     }
> {code}
> Am still looking for the way to fix this, [~jcamachorodriguez]/[~ashutoshc] 
> any idea what is the best way to detect that it is an empty create table 
> statement? 
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to