[ 
https://issues.apache.org/jira/browse/HIVE-18906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434438#comment-16434438
 ] 

BELUGA BEHR commented on HIVE-18906:
------------------------------------

I think what we want here is:

 
 * An INFO message at startup which tells the administrator if the back-end 
database is supported for the direct SQL optimization
 * An INFO message at startup which tells the administrator if the direct SQL 
optimization is enabled/disabled
 * A WARN message if the SQL direct optimization is disabled for a database 
that is supported
 * A DEBUG message for each query if it is using (or not using) direct SQL 
optimization

> Lower Logging for "Using direct SQL"
> ------------------------------------
>
>                 Key: HIVE-18906
>                 URL: https://issues.apache.org/jira/browse/HIVE-18906
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: BELUGA BEHR
>            Assignee: Antal Sinkovits
>            Priority: Trivial
>              Labels: noob
>
> https://github.com/apache/hive/blob/4047befe48c8f762c58d8854e058385c1df151c6/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java#L181
> {code}
> 2018-02-26 14:32:50,620  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-199]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:33:09,566  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:33:43,170  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:33:46,301  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-199]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:34:16,966  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:34:18,072  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-196]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:34:25,064  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-199]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:34:51,781  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:35:04,685  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-199]: 
> Using direct SQL, underlying DB is MYSQL
> 2018-02-26 14:35:26,689  INFO  
> org.apache.hadoop.hive.metastore.MetaStoreDirectSql: [pool-4-thread-172]: 
> Using direct SQL, underlying DB is MYSQL
> {code}
> I wouldn't mind knowing this information when the service starts up and 
> detects that there is a Direct SQL compatible database, but I don't need to 
> know about this every time.
> Please lower to _debug_ level logging and parameterize with SLF4J.  Direct 
> SQL is a performance thing and not something I care about during the normal 
> course of operation (unless there is an error which would presumably be 
> covered by an _error_ logging message).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to