[ 
https://issues.apache.org/jira/browse/HIVE-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437328#comment-16437328
 ] 

BELUGA BEHR commented on HIVE-18902:
------------------------------------

[~bchupika]  Thanks. :)

 

I think what we should do here is perhaps is simply to modify the {{logInfo}} 
method to be called {{logAndAudit}} and then simply change the logging level 
here from 'info' to 'debug'.  The message will be logged at the 'info' level in 
the {{logAuditEvent}} method, so it seems superfluous to log it twice, in two 
locations, at the 'info' level.

 
{code:java}
private static void logAndAudit(String m) {
   LOG.debug("{}: {}", threadLocalId.get(), m);
   logAuditEvent(m);
}{code}

> Lower Logging Level for Cleaning Up "local RawStore"
> ----------------------------------------------------
>
>                 Key: HIVE-18902
>                 URL: https://issues.apache.org/jira/browse/HIVE-18902
>             Project: Hive
>          Issue Type: Improvement
>          Components: Standalone Metastore
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: BELUGA BEHR
>            Assignee: Bohdan Chupika
>            Priority: Trivial
>              Labels: noob
>         Attachments: HIVE-18902.01.patch
>
>
> [https://github.com/apache/hive/blob/7c22d74c8d0eb0650adf6e84e0536127c103e46c/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java#L7756-L7768]
>  
> {code:java}
> private static void cleanupRawStore() {
>   try {
>     RawStore rs = HMSHandler.getRawStore();
>     if (rs != null) {
>       HMSHandler.logInfo("Cleaning up thread local RawStore...");
>       rs.shutdown();
>     }
>   } finally {
>     HMSHandler handler = HMSHandler.threadLocalHMSHandler.get();
>     if (handler != null) {
>       handler.notifyMetaListenersOnShutDown();
>     }
>     HMSHandler.threadLocalHMSHandler.remove();
>     HMSHandler.threadLocalConf.remove();
>     HMSHandler.threadLocalModifiedConfig.remove();
>     HMSHandler.removeRawStore();
>     HMSHandler.logInfo("Done cleaning up thread local RawStore");
>   }
> }
> {code}
> {code}
> 2018-03-03 17:21:49,832  INFO  
> org.apache.hadoop.hive.metastore.HiveMetaStore: [pool-4-thread-21]: 19: 
> Cleaning up thread local RawStore...
> 2018-03-03 17:21:49,834  INFO  
> org.apache.hadoop.hive.metastore.HiveMetaStore: [pool-4-thread-21]: 19: Done 
> cleaning up thread local RawStore
> {code}
> Not very helpful logging.  Please change logging levels to _debug_ or even 
> _trace_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to