[
https://issues.apache.org/jira/browse/HIVE-19200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439396#comment-16439396
]
Hive QA commented on HIVE-19200:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
45s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
15s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
47s{color} | {color:red} ql: The patch generated 5 new + 333 unchanged - 2
fixed = 338 total (was 335) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch has 6 line(s) that end in whitespace. Use git
apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
5s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 17m 39s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10250/dev-support/hive-personality.sh
|
| git revision | master / 6bd32a0 |
| Default Java | 1.8.0_111 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10250/yetus/diff-checkstyle-ql.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10250/yetus/whitespace-eol.txt
|
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10250/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10250/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Vectorization: Disable vectorization for LLAP I/O when a
> non-VECTORIZED_INPUT_FILE_FORMAT mode is needed (i.e. rows) and data type
> conversion is needed
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: HIVE-19200
> URL: https://issues.apache.org/jira/browse/HIVE-19200
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Affects Versions: 3.0.0
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Critical
> Fix For: 3.0.0
>
> Attachments: HIVE-19200.01.patch, HIVE-19200.02.patch
>
>
> Disable vectorization for issue in HIVE-18763 until we can do the harder VRB
> conversion code.
> The main changes are:
> 1) In the Vectorizer, detect if data type conversion is needed between the
> partition and the desired table schema. If so and LLAP I/O is enabled that
> does encoded catching, then do not vectorize. Why? When LLAP I/O is in
> encoded catching mode, it delivers VectorizedRowBatch (VRB) to the
> VectorMapOperator instead of (object) rows. We currently do not have logic
> for converting VRBs. So, we either get Wrong Results or more likely
> ClassCastException on the expected vs actual ColumnVector columns.
> 2) Cleaned up error message logic.that was suppressing the new message from
> the EXPLAIN VECTORIZATION display.
> 3) NOTE: Some of the SELECT statements in the schema_evol_test*.q are
> commented out because I bumped into a another bug. I'll file that one soon
> and add comments to the Q files.
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------
> The longer-term solution can be done later in steps:
> 1) Write a new code that can take a VectorizedRowBatch (VRB) and convert
> columns to different data types. This is needed when LLAP is doing its
> encoding / caching and feeds VRBs to VectorMapOperator instead of rows.
> Similar to what MapOperator does today, VectorMapOperator would need to be
> enhanced to convert partition VRBs into the table schema VRBs that the vector
> operator tree expect.
> 2) Today, vectorization logic is strictly positional based. It insists that
> the partition columns have the same names as the table schema. The
> MapOperator (and ORC) does more general conversion that uses column names
> instead of column position. We'd need to enhance all 3 classes to handle
> column name based conversion. The 3 classes are: the new VRB-to-VRB
> conversion class, VectorDeserializeRow, and VectorAssignRow.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
