[
https://issues.apache.org/jira/browse/HIVE-17838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444233#comment-16444233
]
Sahil Takiar commented on HIVE-17838:
-------------------------------------
Brief summary of the changes:
* Changed several of the messages in {{ErrorMsg.java}}, specifically, the ones
related to failure to create a Spark session; now the messages include the
session id
* Added a new interface called {{Message}}; all objects sent over the
"HoS-Remote Driver" connection now extend this interface
** This interface basically adds a description to each object sent over the
wire, this way if an exception is caught while trying to serialize or send a
message over the connection, we can print a descriptive message describing what
object we failed to send
* Instead of referring to the "HoS-Remote Driver" as a generic "RPC"
connection, it it now referred to as the "Remote Spark Driver to HiveServer2
connection"
* Made some of the log statements in the RPC library HoS specific
** The RPC library was designed to be generic enough to be used anywhere, but
right now we only use it for HoS, so I think making the logs specific to HoS is
fine
* Moved some log lines related to the RPC library to TRACE log-level, rather
than DEBUG level
** This was done because even at DEBUG mode, its not very useful to log a line
for every message sent over the connection
* Various spelling and formatting fixes for log / exception statements related
to HoS
** Rather than logging things like {{Trying to open Spark session}} I've
changed it to {{Trying to open Hive on Spark session}} this should be users
differentiate between logs from Spark itself, and HoS specific logging
> Make org.apache.hive.spark.client.rpc logging HoS specific and other logging
> cleanup
> ------------------------------------------------------------------------------------
>
> Key: HIVE-17838
> URL: https://issues.apache.org/jira/browse/HIVE-17838
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: Sahil Takiar
> Assignee: Sahil Takiar
> Priority: Major
> Attachments: HIVE-17838.1.patch, HIVE-17838.2.patch
>
>
> A lot of the logging in {{org.apache.hive.spark.client.rpc}} emits
> information that a generic RPC library would, but this package is only used
> by HoS. We should make the logging more HoS specific so users don't get
> confused as to what this RPC library is doing. Ideally, they aren't even
> aware that a RPC library is in place, it should be more transparent to the
> user.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
