[ 
https://issues.apache.org/jira/browse/HIVE-19124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451283#comment-16451283
 ] 

Eugene Koifman commented on HIVE-19124:
---------------------------------------

My point was that instead of letting the Driver create the list, the list 
created by Worker should be passed to the Driver.  That way it doesn't have to 
extract any ids, does it?  (and the flow between MM and acid remains more 
similar)
This is the code from Worker that I'm referring to 
{noformat}
        String fullTableName = TxnUtils.getFullTableName(t.getDbName(), 
t.getTableName());
        GetValidWriteIdsRequest rqst = new 
GetValidWriteIdsRequest(Collections.singletonList(fullTableName), null);
        final ValidWriteIdList tblValidWriteIds =
                
TxnUtils.createValidCompactWriteIdList(txnHandler.getValidWriteIds(rqst).getTblValidWriteIds().get(0));
        LOG.debug("ValidCompactWriteIdList: " + 
tblValidWriteIds.writeToString());
        txnHandler.setCompactionHighestWriteId(ci, 
tblValidWriteIds.getHighWatermark());
{noformat}


> implement a basic major compactor for MM tables
> -----------------------------------------------
>
>                 Key: HIVE-19124
>                 URL: https://issues.apache.org/jira/browse/HIVE-19124
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Major
>              Labels: mm-gap-2
>         Attachments: HIVE-19124.01.patch, HIVE-19124.02.patch, 
> HIVE-19124.03.patch, HIVE-19124.03.patch, HIVE-19124.04.patch, 
> HIVE-19124.05.patch, HIVE-19124.06.patch, HIVE-19124.07.patch, 
> HIVE-19124.08.patch, HIVE-19124.patch
>
>
> For now, it will run a query directly and only major compactions will be 
> supported.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to