[
https://issues.apache.org/jira/browse/HIVE-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592870#comment-14592870
]
Gunther Hagleitner commented on HIVE-10233:
-------------------------------------------
Partial review:
* There's some unnecessary commented out code in HashTableLoader (NOCOND..)
* getOutputMemoryNeeded isn't referenced anywhere. I think this can be
dropped together with setOutputMemoryNeeded + references.
* IMO a definition of ONE_MB makes no sense might as well use the number in
the code
* Same for getInputMemoryNeededFraction
* memoryInUse in AbstractOperatorDesc isn't used anywhere
* || (conf.getBoolVar(HiveConf.ConfVars.HIVEUSEHYBRIDGRACEHASHJOIN))) {
did you mean to say &&? Are you trying to run the mem manager only if tez and
hybrid?
* You set a work's memory usage to the data size of it's terminal operator.
How come?
> Hive on tez: memory manager for grace hash join
> -----------------------------------------------
>
> Key: HIVE-10233
> URL: https://issues.apache.org/jira/browse/HIVE-10233
> Project: Hive
> Issue Type: Bug
> Components: Tez
> Affects Versions: llap, 2.0.0
> Reporter: Vikram Dixit K
> Assignee: Vikram Dixit K
> Attachments: HIVE-10233-WIP-2.patch, HIVE-10233-WIP-3.patch,
> HIVE-10233-WIP-4.patch, HIVE-10233-WIP-5.patch, HIVE-10233-WIP-6.patch,
> HIVE-10233-WIP-7.patch, HIVE-10233-WIP-8.patch, HIVE-10233.08.patch,
> HIVE-10233.09.patch
>
>
> We need a memory manager in llap/tez to manage the usage of memory across
> threads.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
