[ https://issues.apache.org/jira/browse/HIVE-19400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462855#comment-16462855 ]
Miklos Gergely commented on HIVE-19400: --------------------------------------- [~ekoifman] I don't see how TestTxnExIm.testUpgrade() works as a test: it creates a lot of tables, runs the upgrade tool, then it doesn't make any assertions. What should I modify in the absence of assertions? It still works without parameters, it logs a little bit differently, and it'll create the script files only if they are needed, but none of these things is actually tested. How do you run this test? "mvn -Dtest=TestTxnExIm" test fails for me on the master branch. > Adjust Hive 1.0 to 2.0 conversion utility to the upgrade > -------------------------------------------------------- > > Key: HIVE-19400 > URL: https://issues.apache.org/jira/browse/HIVE-19400 > Project: Hive > Issue Type: Sub-task > Components: Hive > Affects Versions: 3.0.0 > Reporter: Miklos Gergely > Assignee: Miklos Gergely > Priority: Major > Fix For: 3.0.0 > > Attachments: HIVE-19400.01.patch > > > Conversion utility should allow specification of the output dir, and create > files only if there is actually something to do. -- This message was sent by Atlassian JIRA (v7.6.3#76005)