[
https://issues.apache.org/jira/browse/HIVE-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465616#comment-16465616
]
Hive QA commented on HIVE-19161:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
40s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
15s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
34s{color} | {color:blue} common in master has 62 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
29s{color} | {color:blue} accumulo-handler in master has 22 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
37s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
22s{color} | {color:blue} jdbc-handler in master has 11 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
19s{color} | {color:blue} ql in master has 2318 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
40s{color} | {color:blue} service in master has 49 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
8s{color} | {color:blue} standalone-metastore in master has 214 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m
31s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
17s{color} | {color:red} accumulo-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
20s{color} | {color:red} hcatalog-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
31s{color} | {color:red} hive-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
13s{color} | {color:red} jdbc-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
58s{color} | {color:red} ql in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m
21s{color} | {color:red} service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
19s{color} | {color:red} accumulo-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
32s{color} | {color:red} hive-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
13s{color} | {color:red} jdbc-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} compile {color} | {color:red} 0m
19s{color} | {color:red} service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s{color}
| {color:red} accumulo-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 32s{color}
| {color:red} hive-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 13s{color}
| {color:red} jdbc-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 19s{color}
| {color:red} service in the patch failed. {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
19s{color} | {color:green} The patch common passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
14s{color} | {color:green} accumulo-handler: The patch generated 0 new + 5
unchanged - 15 fixed = 5 total (was 20) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} The patch hcatalog-unit passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
16s{color} | {color:red} itests/hive-unit: The patch generated 2 new + 2
unchanged - 0 fixed = 4 total (was 2) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch jdbc-handler passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
9s{color} | {color:green} The patch metastore passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
42s{color} | {color:red} ql: The patch generated 13 new + 138 unchanged - 0
fixed = 151 total (was 138) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} The patch service passed checkstyle {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
34s{color} | {color:red} standalone-metastore: The patch generated 1 new + 1512
unchanged - 1 fixed = 1513 total (was 1513) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 27 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
18s{color} | {color:red} accumulo-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
34s{color} | {color:red} hive-unit in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
13s{color} | {color:red} jdbc-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
32s{color} | {color:red} ql generated 3 new + 2318 unchanged - 0 fixed = 2321
total (was 2318) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
19s{color} | {color:red} service in the patch failed. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m
28s{color} | {color:red} standalone-metastore generated 1 new + 214 unchanged -
0 fixed = 215 total (was 214) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
14s{color} | {color:red} accumulo-handler generated 3 new + 0 unchanged - 0
fixed = 3 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
10s{color} | {color:red} jdbc-handler generated 1 new + 1 unchanged - 0 fixed =
2 total (was 1) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m
17s{color} | {color:red} service generated 1 new + 40 unchanged - 0 fixed = 41
total (was 40) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 1m
3s{color} | {color:red} standalone-metastore generated 1 new + 55 unchanged - 0
fixed = 56 total (was 55) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 56m 53s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | Exceptional return value of java.io.File.mkdirs() ignored in
org.apache.hadoop.hive.ql.metadata.JarUtils.jarFinderGetJar(Class) At
JarUtils.java:ignored in
org.apache.hadoop.hive.ql.metadata.JarUtils.jarFinderGetJar(Class) At
JarUtils.java:[line 260] |
| | Redundant nullcheck of
org.apache.hadoop.hive.ql.udf.generic.GenericUDFCurrentGroups.currentGroups,
which is known to be non-null in
org.apache.hadoop.hive.ql.udf.generic.GenericUDFCurrentGroups.copyToNewInstance(Object)
Redundant null check at GenericUDFCurrentGroups.java:is known to be non-null
in
org.apache.hadoop.hive.ql.udf.generic.GenericUDFCurrentGroups.copyToNewInstance(Object)
Redundant null check at GenericUDFCurrentGroups.java:[line 90] |
| | Repeated conditional test in
org.apache.hadoop.hive.ql.udf.generic.GenericUDFCurrentGroups.copyToNewInstance(Object)
At GenericUDFCurrentGroups.java: At GenericUDFCurrentGroups.java:[line 89] |
| FindBugs | module:standalone-metastore |
| | Should
org.apache.hadoop.hive.metastore.ObjectStore$PrivilegeWithoutCreateTimeComparator
be a _static_ inner class? At ObjectStore.java:inner class? At
ObjectStore.java:[lines 6079-6089] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile
xml |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-10741/dev-support/hive-personality.sh
|
| git revision | master / 88d224f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-mvninstall-accumulo-handler.txt
|
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-mvninstall-itests_hcatalog-unit.txt
|
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-mvninstall-itests_hive-unit.txt
|
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-mvninstall-jdbc-handler.txt
|
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-mvninstall-ql.txt
|
| mvninstall |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-mvninstall-service.txt
|
| compile |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-compile-accumulo-handler.txt
|
| compile |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-compile-itests_hive-unit.txt
|
| compile |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-compile-jdbc-handler.txt
|
| compile |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-compile-service.txt
|
| javac |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-compile-accumulo-handler.txt
|
| javac |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-compile-itests_hive-unit.txt
|
| javac |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-compile-jdbc-handler.txt
|
| javac |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-compile-service.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/diff-checkstyle-itests_hive-unit.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/diff-checkstyle-ql.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/diff-checkstyle-standalone-metastore.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-findbugs-accumulo-handler.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-findbugs-itests_hive-unit.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-findbugs-jdbc-handler.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/new-findbugs-ql.html
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/patch-findbugs-service.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/new-findbugs-standalone-metastore.html
|
| javadoc |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/diff-javadoc-javadoc-accumulo-handler.txt
|
| javadoc |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/diff-javadoc-javadoc-jdbc-handler.txt
|
| javadoc |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/diff-javadoc-javadoc-service.txt
|
| javadoc |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus/diff-javadoc-javadoc-standalone-metastore.txt
|
| modules | C: common accumulo-handler itests/hcatalog-unit itests/hive-unit
jdbc-handler metastore ql service standalone-metastore U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-10741/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Add authorizations to information schema
> ----------------------------------------
>
> Key: HIVE-19161
> URL: https://issues.apache.org/jira/browse/HIVE-19161
> Project: Hive
> Issue Type: Improvement
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Priority: Major
> Attachments: HIVE-19161.1.patch, HIVE-19161.10.patch,
> HIVE-19161.11.patch, HIVE-19161.12.patch, HIVE-19161.13.patch,
> HIVE-19161.14.patch, HIVE-19161.15.patch, HIVE-19161.2.patch,
> HIVE-19161.3.patch, HIVE-19161.4.patch, HIVE-19161.5.patch,
> HIVE-19161.6.patch, HIVE-19161.7.patch, HIVE-19161.8.patch, HIVE-19161.9.patch
>
>
> We need to control the access of information schema so user can only query
> the information authorized to.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
