[ 
https://issues.apache.org/jira/browse/HIVE-19041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469680#comment-16469680
 ] 

Vihang Karajgaonkar commented on HIVE-19041:
--------------------------------------------

Talked with [~stakiar] offline. Removed {{AddPartitionsRequest}}, 
{{DropPartitionsRequest}}, {{AddDynamicPartitionsRequest}} and 
{{PartitionsStatsRequest}} from the patch since these are request objects and 
it is very unlikely that duplicate strings from these objects overwhelm the 
heap. The {{Partition}} list in these objects will however will interned 
because of the changes to Partition class from this patch.

> Thrift deserialization of Partition objects should intern fields
> ----------------------------------------------------------------
>
>                 Key: HIVE-19041
>                 URL: https://issues.apache.org/jira/browse/HIVE-19041
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 3.0.0, 2.3.2
>            Reporter: Vihang Karajgaonkar
>            Assignee: Vihang Karajgaonkar
>            Priority: Major
>         Attachments: HIVE-19041.01.patch, HIVE-19041.02.patch, 
> HIVE-19041.03.patch, HIVE-19041.04.patch
>
>
> When a client is creating large number of partitions, the thrift objects are 
> deserialized into Partition objects. The read method of these objects does 
> not intern the inputformat, location, outputformat which cause large number 
> of duplicate Strings in the HMS memory. We should intern these objects while 
> deserialization to reduce memory pressure. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to